Download & Extend

Better Views support in xspf_playlist_views (omit playlist item attributes from the playlist)

Project:XSPF Playlist
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

This patch builds on the word I did for #354374: Update XSPF Views to Views 2 and adds several options to the Views row style plugin to allow certain items to be omited from the playlist (creator, image, info, and title).

The patch should apply cleanly to CVS, as the code I submitted in #354374: Update XSPF Views to Views 2 has already been commited.

AttachmentSize
xspf_playlist_views_options.patch3.88 KB

Comments

#1

I was interested in checking out what you've got going here....

I wasn't able to apply your first patch, however, on either a alpha1 or alpha2 xspf module (even when I used your -p1 from the modules directory tip). I was able to get your second patch to apply, but it appears to only build on your first patch, in that it doesn't seem to do anything for me.

Any idea when we'll be able to see a release with this improved functionality?

#2

to apply the patch for testing... do a checkout of the alpha2 from the cvs repo.
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d xspf_playlist-DRUPAL-6--1-0-ALPHA2 -r DRUPAL-6--1-0-ALPHA2 contributions/modules/xspf_playlist/

then cd to the directory of the xspf_playlist_views module:
cd xspf_playlist-DRUPAL-6--1-0-ALPHA2/xspf_playlist_views/

Then download the above patch into this directory and run one more command at the terminal:
patch -p0 < xspf_playlist_views_options.patch

I have this patch successfully applied and I am off to test it now.

#3

Status:needs review» reviewed & tested by the community

This patch is working just fine for nodes. I personally need another style plugin to handle files so this doesn't really do what I need. I want to create a view that grabs a list of all mp3 files on the server and creates an xspf from them. I may try my hand at it if I can find time, but I won't say that I am working on it for sure.

I suggest committing this patch to the current module.

#4

Anyone have any ideas on converting this to work for files instead of nodes? I have tried and my views experience just seems a bit under par.

#5

Version:6.x-1.0-alpha2» 6.x-1.x-dev
Status:reviewed & tested by the community» needs work

doesn't apply to the 6.x-1.x-dev version.

#6

I applied the patch manually (please submit to DEV!) and I get a playlist with thumbnails, but:

  • playlist items appear duplicate: the first with the file description and a second duplicate with the node title
  • An attempt to play an item from the list fails with the message: Loaded file is not a valid media provider (JW player 5.1)
  • the annotation is missing

Would be nice to have the options:

  • to choose what will be the title (node title or file description or none)
  • to choose what will be the annotation (node body or teaser or none)

#7

doesn't apply anymore, as the code's been refactored in the second version (and i'm pretty sure we're not going to focus on version 1 anymore). most of this patch is thus obsolete, as we're no longer using xspf_playlist_node.module.

#8

Version:6.x-1.x-dev» 6.x-2.x-dev