Support Activity 6.2

Do you have the Twitter module installed? I made a mistake in the Twitter integration that can cause this to happen...

What version of PHP do you have? What type and version of SQL? Do you have any JavaScript-related modules installed?

What pages is this happening on? Are there multiple status update forms on the same page?

Did you upgrade from a previous version of FBSS or install it for the first time? If you upgraded, did you run update.php?

This is a really vague error (status code 500 basically means "something's wrong but the server doesn't know what") and I haven't experienced your problem (unless it's related to Twitter) so I will need to know as much information as you can give me about your system in order to solve this problem.

I'm not sure how you know that it's using JQuery 1.2.6, but if you think this is the case even though you're using JQuery Update, this is probably a bug with JQuery Update (or you may not have installed it correctly). FBSS handles very little of its own JavaScript; most of it is default Drupal behavior, so I'd say the issue likely rests with one of the JQuery modules you're using.

Of course, there could be a conflict between FBSS and one of those modules, rather than the fault lying entirely on those modules.

At this point I recommend that you uninstall all JQuery-related modules one by one, reversing whatever steps you took to install them (for instance, you're supposed to replace core Drupal files when you install JQuery Update) and test FBSS after each one to see if it works. If you find the one that's the conflict, reinstall it, carefully following the install/upgrade instructions. If the conflict is still there, at least we know which module to address.

Yes, the ID is fine. It's just the name of the function that defines the form, _facebook_status_status, with underscores converted to hyphens.

If you're using JQuery 1.3.2, you haven't disabled all extraneous JavaScript modules; you're still using JQuery Update, even if the module itself is disabled. Please try to revert to the state of JavaScript you'd have with a clean Drupal install (JQuery 1.2.6 with no JS modules enabled).

Wow, I definitely didn't expect that... thanks for being so cooperative in helping to track this down. I'm really busy this week but I'll try to look into it also. Actually now that I think about it, I'm not surprised it doesn't work, because I'm pretty sure I wrote the integration for Activity 1.x. Hmm. It used to be that I would have problems with people being on Activity 4.x instead of the stable 3.x branch... people just aren't getting what they need out of that module yet evidently, heh. It's getting there though...

Anyway, it should be possible for me to provide integration with both branches, but it will be a little bit until I have time to figure that one out, so marking as postponed. Do let me know if the Activity 1.x integration works though, because the testing I did on that was very light compared to how much I've tested all the other features, and I'm probably missing some steps (like if a status is deleted, the corresponding Activity record isn't deleted with it).

Integration with Activity 2.x is rather simple (at first look). The module has good developer documentation and the good example of integration is flag_friend module. I undrestand code but have poor experience to integrate both branches together.

My experience working with Activity has been that the developers are great people who are nice to work with, but documentation used to be pretty sparse. I haven't checked in awhile though and I'll try to get to that this weekend if possible although it may be the following weekend before I have a chance.

Subscribe.
I have the same error after installing Activity 2 module.

Activity 6.2 integration is partially fixed locally (will be in CVS soon). Basically, there are no errors anywhere, and setting up Activity messages basically works, but they don't get recorded when a status is submitted. I'm not sure why that is, but it's quite befuddling. I think part of the problem is that the new access control system seems really limiting.

Marking with the activity2-integration tag to hopefully get some eyes on this from the Activity maintainers...

Alright, so there was an obstacle: Trigger integration was broken and I didn't know it. But it's fixed now, and Activity 2 integration works, albeit with an error about being unable to insert a row into {activity_targets}, and with the caveat that FBSS tokens aren't getting run for some reason.

This is the last thing on my to-do list before RC, unless other bug reports pop up, so I'd love some help on this if anyone is capable of helping.

Having said that, the DB error seems to be related to the fact the Activity doesn't seem to want to take two "user" parameters in the $context from the trigger functions, so fixing that might have to be postponed until Activity 2 is more mature. I really have no idea about the token replacement, but it's not going anywhere fast.

I'll be AFK next week. If no one does any work on this before I get back, I'm going to mark back to postponed and just go ahead and release the RC.

This is a feature that needs work and isn't completely in yet, not a bug report on an existing feature. This is particularly true because I don't know whether the problem is in FBSS or Activity.

looking at the codes in facebook_status.module the function

 /**
     * Implementation of hook_activity_info().
     */
    function flag_friend_activity_info() {
      $token_types['facebook_status'] = t('Facebook-style Statuses');
  return array(
    'ops' => array('update' => t('Submit Status Update')),
    'types' => $token_types,
    'roles' => array(
      'owner' => array(
        '#name' => t('Owner'),
        '#description' => t('The user whose profile the status was posted on.'),
        '#default' => 'You have a new post on your profile.',
      ),
      'poster' => array(
        '#name' => t('Poster'),
        '#description' => t('The user who posted the status.'),
        '#default' => "You posted a status on [owner]'s profile.",
      ),
      'all' => array(
        '#name' => t('All'),
        '#description' => t('Everyone who can see status updates.'),
        '#default' => "[poster] posted on [owner]'s profile.",
      ),
    ),
  );
}

should be installed for basic information exchange with activity 2 which is same as activity 1, and is already present.

Then

/** 
 * Implementation of hook_activityapi().
 * I have no idea why this is actually necessary.
 */
function facebook_status_activityapi(&$activity, $op) {
  if ($op == 'load') {
    if ($activity['data']['module'] == 'facebook_status' && user_access('view all statuses')) {
      $activity = array();
    }
  }
}

is replaced with the name function

function facebook_status_activityapi(&$activity, $op) with
function facebook_status_activity_access_api(&$activity, $op)

then again looking at this block

/**
 * Handles recording activity messages.
 *
 * @param $account
 *   The $user object of the owner of the status.
 * @param $status
 *   The status object containing the status to record. Requires at least the
 *   status and status_time.
 */
function facebook_status_activity($owner, $poster, $status) {
  if (!module_exists('activity')) {
    return FALSE;
  }
  //Privacy setting check.
  //if (activity_user_privacy_optout($account)) {
  //  return FALSE;
  //}
  $data = array(
    'operation' => 'update',
    'owner' => theme('username', $owner),
    'poster' => theme('username', $poster),
    'status' => check_plain($status->status),
    'status_time' => $status->status_time,
  );
  $target_users_roles = array(
    ACTIVITY_ALL => 'all',
    $owner->uid => 'owner',
  );
  if ($owner->uid != $poster->uid) {
    $target_users_roles[$poster->uid] = 'poster';
  }
  activity_insert($account->uid, 'facebook_status', 'status', 'update', $data, $target_users_roles);
}

i found you need to replace the function name with:

function facebook_status_activity($owner, $poster, $status)
to
function facebook_status_activity_grants($owner, $poster, $status)

comment out this lines because in activity2 we dont need this

//Privacy setting check.
  //if (activity_user_privacy_optout($account)) {
  //  return FALSE;
  //}

need to search what
activity_insert($account->uid, 'facebook_status', 'status', 'update', $data, $target_users_roles);

can be replaced with. I think you need more instances of activity function... a little help from here:>>

function activity_record($object, $context) 

will be used instead....

I was just going through and checking up
Never Mind that i made the status to bug-fix because i thought activity2 is now used by many!!
Sorry!! ;)

Thanks for your help!

A few things: first of all it looks like you're looking at the Beta 4 release instead of the most recent dev (which has the almost-complete integration in it). Also, my goal is not to replace Activity 1 integration with Activity 2, it's to integrate with both. To that end, we get functions like this:

/**
 * Implementation of hook_activity_info().
 * Activity 1 and 2.
 */
function facebook_status_activity_info() {
  //This function only exists if Activity 2.x is in use.
  if (function_exists('activity_action_info')) {
    $info = new stdClass();
    $info->api = 2;
    $info->name = 'facebook_status';
    $info->object_type = 'facebook_status';
    $info->objects = array('owner' => 'facebook_status', 'poster' => 'user');
    $info->hooks = array('facebook_status' => array('fbss_submitted'));
    return $info;
  }
  //We're using Activity 1.x.
  return array(
    'ops' => array(
      'update' => t('Submit Status Update')
    ),
    'types' => array('facebook_status' => 'Facebook-style Statuses'),
    'roles' => array(
      'owner' => array(
        '#name' => t('Owner'),
        '#description' => t('The user whose profile the status was posted on.'),
        '#default' => array(
          'update' => 'You have a new post on your profile.',
        ),
      ),
      'poster' => array(
        '#name' => t('Poster'),
        '#description' => t('The user who posted the status.'),
        '#default' => array(
          'update' => "You posted a status on [owner]'s profile.",
        ),
      ),
      'all' => array(
        '#name' => t('All'),
        '#description' => t('Everyone who can see status updates.'),
        '#default' => array(
          'update' => "[poster] posted on [owner]'s profile.",
        ),
      ),
    ),
  );
}

That is in fact the only function required for Activity 2 integration. I've been through the developer docs several times and I can't figure out why this is not enough. I've tried using the optional hooks as well and the result doesn't change.

I've tracked the problem to the fact that the activity_record() function in Activity 2, which seems to somehow get called by the Trigger module, doesn't have the right UID in $context['facebook_status']->uid. That would be related to the Trigger integration in FBSS presumably, which looks like this:

/**
 * Implementation of hook_hook_info().
 */
function facebook_status_hook_info() {
  return array(
    'facebook_status' => array(
      'facebook_status' => array(
        'fbss_submitted' => array(
          'runs when' => t('The status update form has been submitted.'),
        ),
      ),
    ),
  );
}

/**
 * Implementation of hook_facebook_status().
 * or
 * Implementation of hook_trigger_name().
 */
function facebook_status_facebook_status($op, $owner, $poster) {
  if (!in_array($op, array('fbss_submitted'))) {
    return;
  }
  $aids = _trigger_get_hook_aids('facebook_status', $op);
  $context = array(
    'hook' => 'facebook_status',
    'op' => $op,
    'owner' => $owner,
    'poster' => $poster,
  );
  actions_do(array_keys($aids), $poster, $context);
}

...however, that works for Trigger, so I would have expected it to work for Activity as well. I'm quite confused about that right now.

Finally, the function facebook_status_activity is not part of Activity integration at all--it's a helper function I wrote to simplify the process for Activity 1.

Thanks for your help though! Hopefully this will get figured out soon.

Subscribing and personally volunteer to fix it for ya. (/me one of the maintainers of Activity2)

This would be the icing on the cake for a personal project of mine. No input to make I'm afraid but figured this is better than just saying "subscribe". Best of luck with your efforts.

@Scott: Awesome, thanks! As I said I'll be gone next week but of course let me know if there's anything I can do for you.

@adrianlewis: Thanks. :)

Ohkay i get it!! I am soo sorry!! i did not noticed the dev version..... well i will check it out and let you inform if i can help you ;)

That's perfectly fine--it's always a good thing to try to help, even if that help is a little misguided. :-) Your effort is appreciated.

Make this:

$info->objects = array('owner' => 'facebook_status', 'poster' => 'user');

Into

$info->objects = array('Author' => 'owner', 'Poster' => 'poster');

There will be a problem though with token replacements as your objects ('owner' and 'poster') are not standard drupal object names ('user', 'account'). This will cause Token to not know how to handle those.

Seems to work--thanks very much. I fixed the tokens too. Will commit momentarily.

Committed, thanks again Scott! Leaving early tomorrow; will post an RC when I get back if there aren't any major bugs.