PostgreSQL does not recognize ifnull in the install file. This patch should fix that.

CommentFileSizeAuthor
#2 pgsql_drupal5_comment_notify_install.patch2.47 KBAnonymous (not verified)
comment_notify_install_psql.patch824 bytesAnonymous (not verified)

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks for your testing and providing a patch!

The "ifnull" function is in three places in this file. Any chance you could fix/test them all?

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new pgsql_drupal5_comment_notify_install.patch2.47 KB

Here you go. there was only one other ifnull which needed to be taken care of because the first ifnull is only used for mysql databases.

I've tested this several times and it installs and runs just fine, sends E-mails and inflates the comments notify table with data from the comments table as expected. I have NOT tested the install update 5 function, but by looking at it you can see that it should "just work".

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Thanks!

Now committed http://drupal.org/cvs?commit=339814

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.