Note: This is not a 'patch' so much as a copy of the actual module -- I figured I would post it here so people can test it and in case someone can help with the final bug.

Here is a 4.6 compatible version of the LT module. Credits to jjeff for writing the initial one, and Mark Burdett of Goodstorm for his subsequent clean-up job. I've fixed some remaining bugs and this is just about ready to go, but it still needs a bit of work.

It still has one outstanding bug that I'm aware of, in that you are not actually redirected to the screen where you were when you login after getting an access deined. Looks like the 4.7 version has this bug too.

All the other options seem to work though, so you should be able to use it right now.

Any help in fixing this or finding other bugs would be appreciated. :) I know a lot of people have been asking for this for a long time.

CommentFileSizeAuthor
#10 logintoboggan_2.module31.99 KBwebchick
#7 logintoboggan_1.module.patch925 bytesmfb
#1 logintoboggan_1.module34.47 KBwebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new logintoboggan_1.module34.47 KB

Hey! How about a copy of the module? ;)

jjeff’s picture

jjeff commented

Well I'll be darned! 4.7 does have that bug.

The logintoboggan_destination() function is supposed to be handling this and either isn't getting called correctly or isn't returning the right stuff.

I'll try to track it down. My guess is that the fix will be the same for both versions.

-Jeff

jjeff’s picture

jjeff commented

Okay, I've fixed the 4.7 (HEAD) version of the module.

Here's the patch:
http://cvs.drupal.org/viewcvs/drupal/contributions/modules/logintoboggan...

For me, the trick was to add a hidden 'destination' field into the form. For you, I think the trick is going to be to essentially the same thing. You can either put the destination field hidden in the form or stick it as a query onto the form() call (that's how it was done before we updated it to work with the new form api - search for the use of logintoboggan_destination() in this: http://cvs.drupal.org/viewcvs/drupal/contributions/modules/logintoboggan... )

Let me know if you need more clues to solve this one for 4.6.

-Jeff

noid’s picture

noid commented

Hi webchick,

Thanks for your great work! (And to Chad, Jeff, and Raven, of course. :)). This module is really crucial for Drupal sites, and will be greatly appreciated by my users, to say the least.

The 4.6 version is working fine in my test site, except for the confirmation link. As I understand from the module's help section, the %login_url becomes the confirmation link. However when I click it, (after creating a test user), it doesn't promote the user to authenticated status. I've tried disabling clean url's, but still no go.

Also, even if I disabled the 'Immediate login' setting, the user is still set to non-authenticated status if the 'Non-authenticated role' is set to 'non-authenticated user' -- I have to set the 'Non-authenticated role' to 'authenticated user' to make sure that the new user has full access. (In this case, the automatic instruction "You must click the verification link in your confirmation mail to gain full access" after registration is not needed, and will have to be edited/deleted.)

Are these observations part of the design for the 4.6 version or actually bugs?

Thanks in advance! :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Yikes. Sounds like probably bugs. I'll dig a bit further.

Just one question. Did you go to the logintoboggan help and copy/paste the template listed there as a starter? Basically, note that login_uri and login_url are two different things, even though they look very similar; login_uri is just the link to the login page, where login_url is the validation link.

Thanks for testing!!

noid’s picture

noid commented

Yes! You're right, webchick. the similar names threw me off. Now, everything's working great. Great job! This module will definitely boost my site's membership, and that's an understatement. :) If before, Drupal was rockin', it's now rockin' and rollin'! :) I love Drupal!!! (Sorry just had a big dinner hehe).

mfb’s picture

mfb
they or he
commented
StatusFileSize
new logintoboggan_1.module.patch925 bytes

This little patch slaps the correct page title on the reset password page.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Closed (fixed)

Ok. I have committed what I have here, plus mfb's patch, plus some other misc. bug fixes to the DRUPAL-4-6 branch of the repository. I'm closing this issue and any other bugs that are found please file against the 4.6 version. Thanks!

Mephist0’s picture

Mephist0 commented

Hi,

You mentioned commenting and adding the patch to your code, but the only download is the original attachment, did you just replace that one?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new logintoboggan_2.module31.99 KB

No, I meant that this can now be found in (or will, shortly) the 4.6.x Modules list. But good call; here is a copy of the module that is there now. :)

amstercad’s picture

amstercad
he, him
commented

Thank you all for your hard work! Thank you, thank you, thank you! I wish I could explain how much this means to me, I've been working with it all day and it does just what I need, with the end-result I sorely needed. Thank you very much! The highlight of 2006 HANDS DOWN!

SavoryMedia’s picture

SavoryMedia commented

I noticed that the LT module (4.6) has some serious problems on redirects when using ugly urls.

When I try to login using the user/login page, I can log in, but I get redirected to this URL:

http://domainname.com//?q=index.phptoboggan/login

Will any of these patches fix this?

SavoryMedia’s picture

SavoryMedia commented

Whoops. The link should be:

http://domainname.com/?q=index.phptoboggan/login