Support for per-bin key prefix

litwol - May 19, 2009 - 17:55
Project:Memcache API and Integration
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:reviewed & tested by the community
Description

I am using this code in production environment and if i was not the one that rolled this patch i would have set this to RTBC, ala NR it is :).

This patch enables more granular key prefix control on per bin level. I also updated README.txt with example how to use this new feature. Some whitespaces were also stripped from line endings which make this patch a little bigger but overall code cleaner.

cheers.

AttachmentSize
memcached.bin-key-prefix.patch6.88 KB

#1

litwol - May 19, 2009 - 18:12

One comment still referenced 'memcache_key_prefix' versus the new 'default_key_prefix' string.

AttachmentSize
memcached.bin-key-prefix.patch 2.03 KB

#2

litwol - May 21, 2009 - 05:17
Status:needs review» needs work

To avoid breaking backward compatability, i think i'll change the default key index to 'memcache_key_prefix' and support both array and single prefix setting. that way with next module update absolutely nothing will break.

#3

litwol - May 21, 2009 - 05:17
Assigned to:Anonymous» litwol

#4

litwol - June 1, 2009 - 05:45
Assigned to:litwol» Anonymous
Status:needs work» needs review

Attached file features the following:
1) granular control of per-bin key prefixes
2) default key prefix for bins that did not specify own key prefix
3) maintain backward compatability for sites that still use single global prefix
4) updated README.txt to include example of pre-bin prefix

AttachmentSize
per-bin-prefix.patch 4.2 KB

#5

litwol - August 15, 2009 - 20:51
Status:needs review» reviewed & tested by the community

Ive been using this on my sites for a long time now without any problems. I'd appreciate it if this patch would be committed. Thanks.

 
 

Drupal is a registered trademark of Dries Buytaert.