Pass in page number to apachesolr_search_execute so that solr_service can return the results from the right page.

CommentFileSizeAuthor
#2 467810.patch2.04 KBaufumy
apachesolr_page.patch1.69 KBaufumy

Comments

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

looks reasonable, but should probably have a default for the param, like:

function apachesolr_search_execute($keys, $filters, $solrsort, $base_path = '', $page = 0) {
aufumy’s picture

aufumy commented
Title: Pass in page number to apachesolr_search_execute » Pass in page number and caller to apachesolr_search_execute
StatusFileSize
new 467810.patch2.04 KB

Made the modification to default page, as well as

Pass in $caller to apachesolr_search_execute, to pass into:
apachesolr_modify_query($query, $params, $caller);

Where $caller = 'apachesolr_search' by default.

Therefore custom search results can be returned, where apachesolr_modify_query can apply to these custom searches instead of all searches.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review

needs review? Looks simple enough.

aufumy’s picture

aufumy commented

:) You're the boss.

I thought that because I created that patch, it could not be the same person to set the status to RTBC.

pwolanin’s picture

pwolanin commented

Well, you left it at needs work, which suggested you did not think it worked yet.

aufumy’s picture

aufumy commented

Actually, I left it at needs review first, you changed it to needs work, because I left out the default page in the function definition.

After I added back that as well as adding in the caller I changed it back to needs review.

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

Hmm, well maybe you meant to change it back, but I actually changed it in #3.

Anyhow, looks fine, doesn't seem to cause any breakage - committed.

aufumy’s picture

aufumy commented

LOL... thanks, obviously I am confused.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.