Invalid argument supplied for foreach() in term.inc

Posted by netdream on May 20, 2009 at 10:13am

Issue Summary

I've found and issue on panels module (or maybe ctools...) that appears when you try to access a panel page with an argument of type "taxonomy term", passed by title, and the same term is available on different vocabularies.

This is the error, returned n times (one for each taxonomy term in different vocabularies)
warning: Invalid argument supplied for foreach() in .../sites/all/modules/ctools/plugins/arguments/term.inc on line 49

The warning raises because in ctools "term.inc" there is:

<?php
     case 'term':
      $terms = taxonomy_get_term_by_name($arg);
      if (count($terms) != 1) {
        foreach ($terms as $potential) {
          foreach ($conf['vids'] as $vid => $active) {
?>

count($terms) is obviously > 1 so it executes the foreach... but $conf['vids'] is not populated...

Steps to reproduce the issue:

Have a term in more than one taxonomy (let's say "mydoubletaxonomyterm", different tids but same visible name)
Add panel page (/admin/build/pages/panel-page/add) with path "test/%term"
Assign context "Taxonomy term" -> "Term title"(not Term ID)
It isn't necessary to add any content to the page...
Try to access page /test/mydoubletaxonomyterm

I tried to force a single vocabulary in the panel by adding a new Context (Contexts->Add Context->Taxonomy vocabulary) and forcing one vocabulary... but it doesn't work as expected (nor it saves the choosen vocabulary in the form... maybe this is another bug...)

Comments

#1

Posted by jjemmett on June 9, 2009 at 5:10pm

Priority:

normal

» critical

I agree with the above synopsis Panels needs to provide an interface to specify the vocabulary that the term is to come from in the argument form. That interface needs to populate the $conf['vids'] variable in ctools.

#2

Posted by merlinofchaos on August 7, 2009 at 8:12pm

The proper way to fix this is probably to split the argument into two separate arguments, since specific config options are unwieldy. We also need more stuff like Views has where you can use taxonomy synonyms as arguments.

#3

Posted by tauno on August 20, 2009 at 10:47pm

Marked #551084: Same term in two taxonomies causes error in term.inc line 50 as a duplicate of this issue. The bug still exists in the 3.0 release of panels and 1.0 release of ctools.

#4

Posted by petrelharp on September 5, 2009 at 6:01pm

If there is no way to select which taxonomy terms are from, it is unclear what the default behavior should even be. In this case, it might be best to use tid rather than term name.

#5

Posted by mactoph on September 17, 2009 at 6:45am

For reference, in my case I have duplicate terms in two different vocabularies and would like to pull content from both of those terms into a vocabulary page- that functionality works fine, but it does throw the error.

#6

Posted by petrelharp on October 21, 2009 at 6:31pm

Is there a workaround to make the error invisible to the end users?

#7

Posted by petrelharp on October 25, 2009 at 5:13am

More information about this bug: it's turned out to be quite bad on one of my sites, since if a user adds a term to a free tagging taxonomy that is identical to one in another taxonomy (as they are wont to do), it makes error messages appear on *all* pages, even the administration pages.

Inserting a call to dsm() in term.inc, it seems that for some reason, once there are identical taxonomy terms, ctools_term_context() is getting called with *that* term as an argument *twice*, on *all pages*. This isn't coming from blocks, since it's happening even on administration pages that use Garland and no blocks. This seems strange.
If the taxonomies are hierarchical, this is only a problem if the terms are in the top level (perhaps, at the same level?) -- if in the free tagging taxonomy, I add a top-level (parent) term in the other vocabulary, the error occurs; but if I add a term identical to a child term in the other vocabulary, nothing happens.
As a workaround, I've just removed everything inside the if clause (lines 48-58 of terms.inc). I haven't found this being a problem, anywhere. What should this break?

Hope this helps.

#8

Posted by vood002 on November 3, 2009 at 5:48pm

@petrelharp: Just change your error reporting settings at admin/settings/error-reporting

Or...in other words...subscribing

#9

Posted by dalin on November 9, 2009 at 6:27am

@petrelharp a safer workaround is to change the if line to
if (count($terms) > 1) {
That way the original handling of when count($terms) == 1 is still retained.

I'm submitting this as a patch for someone who knows what this function does to review. I too find it disconcerting that this function is being called on every page, even the admin section.

Attachment	Size
ctools_foreach_error.diff	539 bytes

#10

Posted by dalin on November 9, 2009 at 6:27am

Status:

active

» needs review

#11

Posted by jjemmett on December 28, 2009 at 8:22pm

subscribing

patch did not fix any error for me. Still have problem with the fact that $conf['vids'] is unpopulated.

#12

Posted by jjemmett on December 28, 2009 at 8:22pm

Status:

needs review

» needs work

#13

Posted by pazzypunk on January 8, 2010 at 9:08pm

Is there no way to avoid this by selecting a vocabulary for a pane so that it only looks for a term in that vocabulary? Seems logical but I can only figure it out for the view, not the panel.

#14

Posted by dman on February 24, 2010 at 2:15am

Still an issue.

      if (count($terms) > 1) {
        foreach ($terms as $potential) {
          foreach ((array)$conf['vids'] as $vid => $active) {

updated (from #9) made it stop throwing warnings. Not sure about the bigger 'by-vocab' feature right now.

#15

Posted by jlain on February 24, 2010 at 2:08pm

subscribing

#16

Posted by naero on February 25, 2010 at 2:07am

subscribing

#17

Posted by CinemaSaville on March 5, 2010 at 9:04pm

Subscribing

#18

Posted by mikeker on March 12, 2010 at 12:22am

Title:	Invalid argument for ... when using a taxonomy term found in multiple vocabularies	» Invalid argument supplied for foreach() in term.inc
Status:	needs work	» active

It seems to me that there are two issues here:

When $conf['vid'] is unpopulated because the context is derived from the panel's path rather than the panel settings form
When taxonomy_get_term_by_name($arg) returns no matching terms

I don't think it's related to a term being found in multiple taxonomies. (Note: changing the title to reflect that, please change it back if I'm incorrect about this).

I've attached a patch that solves both of these issues, but I'm afraid that I'm treating the symptom and not the cause. The underlying problem is that $conf is not populated if the context is created outside of the pane settings form. Perhaps that's the way it should be? As such, I'm marking this as active until someone with a better understanding of how contexts are passed around can look at this.

Thanks.

- Mike

Attachment	Size
467898.patch	625 bytes

#19

Posted by mikeker on March 19, 2010 at 10:11pm

Status:

active

» needs review

Spent a little more time working with this and I think I've come up with a better solution: allow the user to select one or more vocabularies to limit the context to when converting a path argument to a context. This ensures that $conf['vids'] is set and maintains the existing functionality if the user makes no changes.

- Mike

Attachment	Size
467898-2.patch	1.71 KB

#20

Posted by mikeker on March 19, 2010 at 10:16pm

Project:	Panels	» Chaos tool suite (ctools)
Version:	6.x-3.x-dev	» 6.x-1.x-dev
Component:	Panel pages	» Exportables
Priority:	critical	» normal

Sorry, just realized all this has been going on in the Panels queue. Moving to ctools queue as that's where the fix belongs.

Also reducing the priority -- I hadn't realized that this was originally entered as critical.

#21

Posted by mikeker on March 19, 2010 at 10:17pm

Component:

Exportables

» Plugins system

grumble, grumble... And changing to the correct component... I think.

#22

Posted by greenbeans on March 20, 2010 at 12:07am

This is happening to me when the term in the context has a child term with the same name as another term in a different branch of the same vocabulary. Any ideas how to work around that?

#23

Posted by jbrauer on April 14, 2010 at 7:29am

Status:

needs review

» needs work

upon testing the patch in #19 I get a different error as a result of the patch

warning: array_filter() [function.array-filter]: The first argument should be an array in [...]/sites/all/modules/ctools/plugins/arguments/term.inc on line 47.

#24

Posted by jp.stacey on June 23, 2010 at 10:07am

Status:

needs work

» reviewed & tested by the community

@mikeker - your patch from #19 works well apart from the bug mentioned in #23 if config hasn't been set for that particular pane.

Solution: a trivial change of line 47 to:

<?php
  $conf['vids'] = is_array($conf['vids']) ? array_filter($conf['vids']) : NULL;
?>

Patch re-rolled and attached.

@jbrauer another solution would be to actually configure the vocabulary for your page. That might involve recreating the Panels page, as I can't see any way of editing existing contexts here :-/

Attachment	Size
467898-3.patch.txt	1.63 KB

#25

Posted by merlinofchaos on July 5, 2010 at 7:22pm

Status:

reviewed & tested by the community

» fixed

Committed, thanks! I slightly adjusted the #default_value test.

#26

Posted by System Message on July 19, 2010 at 7:30pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Project:	Chaos tool suite (ctools)
Version:	6.x-1.x-dev
Component:	Plugins system
Category:	bug report
Priority:	normal
Assigned:	Unassigned
Status:	closed (fixed)

Invalid argument supplied for foreach() in term.inc

Jump to:

Issue Summary

Comments