Use l() to generate links

The links on the settings page are generated in a slightly weird way (sorry!) .. This probably explains #445128: Don't identify correct path. The configure links take me to URLs such as http://example.com/admin/settings/SEOChecklist?q=admin/settings/clean-urls. While this works, I don't think it is supposed to!

Should really use http://api.drupal.org/api/function/l/6 which will do the hard work for you (yes if you've not met it, that is a function whose name is a lowercase letter L!!). That function adds the ?q= if necessary.

e.g. remove the ?q= from all the $option_conf_link and change

$conf_link="| &nbsp;<a href='$option_conf_link'>Configure</a> ";

to

$conf_link='| &nbsp;' . l('Configure', $option_conf_link)<a href='$option_conf_link'>Configure</a> ";

BTW this is a v. interesting module, thanks!