Hi,

You may not be aware that coding standards http://drupal.org/coding-standards state that lowercase function names and by implication module names should be used. (Class methods are another matter.) In certain situations (which I don't recall offhand!) things can go horribly wrong if uppercase is used.

There is also http://drupal.org/project/coder which will report many coding standards infringements no doubt!. Although adherence to the standards by contrib modules is not enforced you might want to consider it in order to make maintainability by the community easier and to reduce the likelihood of security vulnerabilities.

HTH!

CommentFileSizeAuthor
#6 seo_checklist-467944-6.patch65.62 KBtraviscarden

Comments

gpk’s picture

gpk commented

Found it: #200628: Problem with update of mixed case module names.

redpuma’s picture

redpuma commented
Version: 5.x-1.3-1 » 6.x-1.0-beta3

I agree with original post, here is why:

The naming of this module has caused me some pain while trying to include it in an install profile.

As the project is "http://drupal.org/project/seo_checklist" and the directory in my sites/all/modules directory also has that name (seo_checklist) it follows (like every other module) that I would add that same text into my install profile. And that's where it all falls down.

So I've now got this one exception where the machine name doesn't follow the convention.

ben finklea’s picture

ben finklea commented
Status: Active » Closed (fixed)

Fixed in 2.0.

traviscarden’s picture

traviscarden commented
Title: Machine name of module should be seo_checklist not SEOChecklist » Module machine name should match project name
Version: 6.x-1.0-beta3 » 7.x-3.x-dev
Status: Closed (fixed) » Active

Any chance of getting the module name to just match the project name (i.e. seo_checklist instead of seochecklist)? At least for the 7.x-3.x branch, which doesn't have a stable release out yet? I agree with @redpuma: it's a simple matter of predictability. If I drush dl seo_checklist I should be able to drush en seo_checklist. It's just another WTF we can save people. I could help with a patch if it would be accepted.

ben finklea’s picture

ben finklea commented

Yes, a patch would be super helpful!!!

traviscarden’s picture

traviscarden commented
Status: Active » Needs review
StatusFileSize
new seo_checklist-467944-6.patch65.62 KB

Here you go! :)

traviscarden’s picture

traviscarden commented
Version: 7.x-3.x-dev » 7.x-4.0-beta1
Status: Needs review » Fixed

Thanks, all. This is fixed in the new 4.x release. Please try it out and give your feedback in the queue!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.