Machine name of module should be seo_checklist not SEOChecklist

gpk - May 20, 2009 - 11:37
Project:SEO Checklist
Version:6.x-1.0-beta3
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi,

You may not be aware that coding standards http://drupal.org/coding-standards state that lowercase function names and by implication module names should be used. (Class methods are another matter.) In certain situations (which I don't recall offhand!) things can go horribly wrong if uppercase is used.

There is also http://drupal.org/project/coder which will report many coding standards infringements no doubt!. Although adherence to the standards by contrib modules is not enforced you might want to consider it in order to make maintainability by the community easier and to reduce the likelihood of security vulnerabilities.

HTH!

#1

gpk - May 30, 2009 - 16:44

#2

redpuma - July 28, 2009 - 10:41
Version:5.x-1.3-1» 6.x-1.0-beta3

I agree with original post, here is why:

The naming of this module has caused me some pain while trying to include it in an install profile.

As the project is "http://drupal.org/project/seo_checklist" and the directory in my sites/all/modules directory also has that name (seo_checklist) it follows (like every other module) that I would add that same text into my install profile. And that's where it all falls down.

So I've now got this one exception where the machine name doesn't follow the convention.

#3

Volacci - August 8, 2009 - 01:06
Status:active» closed

Fixed in 2.0.

 
 

Drupal is a registered trademark of Dries Buytaert.