Icon won't show up

Okay, I'm going to need you to do some testing for me similar to what I asked in the thread that you linked to. Please paste this PHP code in a node/add page and click preview, and copy-paste your results back here.

<pre><?php
global $base_url, $base_path, $base_root;
echo '$base_url:     '. $base_url .'<br />';
echo '$base_path:    '. $base_path .'<br />';
echo '$base_root:    '. $base_root .'<br />';
echo 'base_path():   '. base_path() .'<br />';
echo 'request_uri(): '. request_uri() .'<br />';

echo '<br />';

echo '$_SERVER["SERVER_NAME"]: '. $_SERVER["SERVER_NAME"] .'<br />';
echo '$_SERVER["REQUEST_URI"]: '. $_SERVER["REQUEST_URI"] .'<br />';
echo '$_GET["q"]:              '. $_GET['q'] .'<br />';
echo 'url():                   '. url($_GET['q'], array('absolute' => TRUE)) .'<br />';

echo '<br />';

//This is what the module currently uses for the icon URL.  Play around with it using the variables above and see if you can get it to work.
echo $base_url . base_path() . check_plain(variable_get('tweet_image', $image_location));
?></pre>

Actually--try this:

echo theme('image', variable_get('tweet_image', $image_location));

Um. That's weird. It might be something screwy with your installation then.

What do you get when you run this?

//This should point to the location of your image.  If it doesn't, that's half your problem.
echo variable_get('tweet_image', $image_location);

//This should be the HTML that generates the image, with the correct image URL.
echo check_plain(theme('image', variable_get('tweet_image', $image_location)));

Really, that's it? You should have gotten a result like this:

sites/all/modules/tweet/icon.png
<img src="/sites/all/modules/tweet/icon.png" alt="" title="" width="16" height="16" />

...if that's what you got and you were just simplifying that result, that's fine. If this is the case, what you got is the expected result, and either the image is not in the expected location (which you can change in the settings) or something is wrong with your local installation, or there is a bug in Drupal core. I suggest you navigate to http://localhost/D6/sites/all/modules/tweet/icon.png and make sure the icon is there.

In either case, the code that's in the module currently is not technically "correct" because it doesn't use the core function, so that will be changed.

I've committed the theme('image') change to dev. I'm 98% sure that if it doesn't work after that, it's not a bug in the module: you might not be pointed to the right directory, or your installation is screwy, or there's a bug in core, or there's a bug in your theme.

Good luck, and do let me know if there are any developments.

Okay, cool, no problem. Your testing has actually been unusually responsive and quite useful, so thanks for that.

At this point it's a core/theme and not a module issue. I'm glad it works on your live server, and of course feel free to open another issue if anything else goes wrong.

Interesting, I have the exact same issue on my production site. Looks like you didn't find an actual fix for it though. I'm guessing perhaps there is a conflict going on with another module? Because there certainly isn't anything "screwy" with my install. It's a production environment with everything working.

Switched to the dev version and this problem is now fixed.

The problem arises when you have an installation that is NOT at the root level. That happened at my site which uses: http://mysite.com/beta

All you have to do is change . $base_url . base_path() . to base_path()
The base_path() function is enough.

Also, here is a cute little tweet icon to use.

The module doesn't use that code any more. It now uses a Drupal core theming function that takes care of all that.

Despite this issue being closed, others might find this solution useful.

PROBLEM: The image was not rendering and was instead showing as img tag HTML code. Here's more details.

Having just spent a few hours trying to track down an issue (should have just used a debugger) where the icon would not display and all I got was HTML code of the img tag, it turned out I was using a theme which was an older theme that had used a theme override within it.

The theme I am currently using on GotDrupal.com is amadou

This theme (which has not been updated in a while) has a phptemplate_links override for the theme_links function. This is one of the hazards of using a theme override in template.php and updating drupal core, but not your theme. Drupal had changed theme_links but this is not up-to-date in amadou (which looks like it was a precursor to the updates in drupal's theme.inc)

If an override is provided within the theme you're using, and you download a module like Tweet and you can't figure out why it might not be working, it could be a theme function override problem. You can see the problem file for amadou here

http://drupalcode.org/viewvc/drupal/contributions/themes/amadou/template...

This may be an extreme edge case, but it's a good troubleshooting tip.

SOLUTION: When you're not getting the display expected, test against a core (unaltered theme) and check your template.php file in your theme for a conflicting theme override function. It will save you the headache. For me, I'll be taking some aspirin (just glad I figured it out)