Posted by ckleiman on May 20, 2009 at 8:19pm
Jump to:
| Project: | Mass Contact |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The mass mail module doesn't appear to support html tables. See screenshot http://creatornorthamerica.com/Support/drupal_mass_mail.jpg
It also prints tags that are supposed to be commented out. !-- /skyscraper cell 1 -- is one example. I've omitted the <> brackets surrounding !--/skyscraper cell 1-- so it will show in this post.
The newsletter is supposed to look like this: http://creatornorthamerica.com/Support/CREATOR%20NEWSLETTER21LT.htm
I've been sending this newsletter through my Mambo site for several years and never a problem. I'm mystified why I'm having problems now sending through Drupal. The newsletter template hasn't changed.
Can anyone help?
Comments
#1
Which Input format (directly beneath the Message form field) did you choose?
#2
Full HTML-May I suggest copying the source code from my newsletter located at http://creatornorthamerica.com/Support/CREATOR%20NEWSLETTER21LT.htm
and testing yourself?
#3
I use the Drupal function of check_markup() (http://api.drupal.org/api/function/check_markup/6) to process the message body. That is what is causing your problems.
The reason the comments are showing up is because the first
<is being converted to<, and then the browser doesn't see that as a tag any more.I still haven't figured out why the tables don't show up correctly.
If you want a quick work around, replace the following line:
$body_html .= check_markup($form_state['values']['message'], $form_state['values']['format']);with
$body_html .= $form_state['values']['message'];in the mass_contact.module file, which should be at about line 1196. You won't get the option of specifying your formatting, but you will get your newsletter.
#4
I'm not sure I completely understand. Yes, this fix will correct uncommented lines from appearing. That I understand. But, you also say you don't know why the tables aren't being supported. But you say this fix will give me my newsletter. Does this mean the tables will reproduce as they should? Better yet, is there a way I can preview my newsletter before sending to 500+ recipients?
#5
Can I get a reply to my last question, please?
#6
Your quick workaround worked! I made the change and sent the newsletter this morning. The html formatted correctly and so did the tables. Now, I'll be able to use this module for my monthly newsletters. Many thanks for your help!
#7
Was this ever fixed in the module?
#8
I don't know. The change is easy enough to make yourself and it works. My server won't allow sending more than 320 email per hour so I'm using a program called phplist, instead. Phplist sends the newsletter in 320 email per hour chunks working in conjunction with a Cron job until the list is finished (usually taking a few hours). Another nice feature of phplist is the ability to send a "test" email or "test" newsletter so you can review prior to doing your mass mailing. I highly recommend.
#9
I changed the way input filters are processed for another issue. Try the latest development release and let me know if you're still having this problem.
#10
I've added an option for allowing the admin to en/disable HTML checking, here: http://drupal.org/cvs?commit=433582
I also changed the input filter processing once again.
Hopefully one of those two things will address this issue.