drupal_set_message() for admin only if items sent
douggreen - May 20, 2009 - 21:30
| Project: | Notify by Views |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
This is a simple patch. Please only display the "user(s) immediately notified" if something was sent. Additionally, the $total should be part of t().
| Attachment | Size |
|---|---|
| nodeapi-insert.patch | 523 bytes |
#1
What do you think of this instead? (This is against HEAD, so slightly different starting point.)
#2
No problem using format_plural, but I'd keep the strings as one. There's benefits to both implementations, with your, translators only need to translate "immediately notified by email" once, with mine, they see the context of the message and the word user/users gets translated in context. It's possible that this subtle difference will change the translation in some languages. format_plural sends it's string through t, so these strings do get translated.