From a clean install of drupal 4.7 beta 4 and the latest amazontools-4.7.0.tar.gz there are asin validation problems using create content/amazon node/preview:

if there is a space in the asin, or a '/' at the end, then it gives the error: 'warning: implode(): Bad arguments. in beta4/includes/form.inc on line 247', after which it is possible to submit the page which gives further errors.

two (or more) asins separated by a comma(s) will preview the first asin, but gives 'Query was empty query: in /beta4/includes/database.mysql.inc on line 124.' when the page is submitted creating the node.

As a newbie to Drupal, I'm assuming wrongly formatted asins should be trapped by the module.

There is also an sql duplication error when the same asin is submitted twice.

Comments

Prometheus6’s picture

Assigned: Unassigned » Prometheus6
Status: Active » Fixed

Not really a patch, I moved changes from cvs to the 4.7 branch.

As a newbie to Drupal, I'm assuming wrongly formatted asins should be trapped by the module.

No, you're assuming contributed modules must work 100% with beta versions of core. This (and in my opinion) all 4.7 modules are just as beta as core. Maybe more.

Prometheus6’s picture

Status: Fixed » Closed (fixed)