use #process instead of preprocess (CAPTCHA 6.x-2.x API update)

soxofaan - May 21, 2009 - 21:20
Project:reCAPTCHA
Version:6.x-1.x-dev
Component:reCAPTCHA Captcha
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi Rob,

I'm busy to get the CAPTCHA module for Drupal 6 past Beta and RC state and one of the last issues I'd like to iron out for CAPTCHA 6.x-2.0 is removing the preprocess operation from hook_captcha. For more discussion and details see #463002: Drop preprocess op of hook_captcha?. Feel free to tune in.

In attachment I have a patch that should make the reCAPTCHA module compatible with this API change: it replaces the usage of the custom hook_captcha-preprocess with standard Drupal Form API stuff (mainly a '#process' callback).
Note that this change is also backwards compatible with the "old" CAPTCHA API (CAPTCHA 5.x-3.x and 6.x-1.x), so nobody gets hurt.

AttachmentSize
drop_preprocess.patch2.93 KB

#1

Rob Loach - May 22, 2009 - 04:17

Wow, I like that process array. Committed. When you release the 6.x-2.0 version, I'll hit up a release on reCAPTCHA. Well done, soxofaan!

#2

soxofaan - June 13, 2009 - 22:39

Hi,
I just released CAPTCHA 6.x-2.0-rc1 in which the preprocess op was dropped, so I think you should hit up that reCAPTCHA release.

keep up your good work, rob!

#3

Rob Loach - June 14, 2009 - 05:30
Status:active» fixed

Great! Thanks a lot for reminding me.... reCAPTCHA 6.x-1.2.

I didn't do any work, you did it all. Also, met a Dutch person at the Drupal NYC meet and he said that his girlfriend knows you! Don't know how that works, but it was pretty funny.

#4

System Message - June 28, 2009 - 05:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.