Posted by sun on May 22, 2009 at 2:47am
5 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
We are testing the error/exception handler in common.test currently. Explicitly referencing line numbers in system_test.module. If any lines above the expected line number are changed, the error handler test fails.
Let's make it pass more often.
This is critical, because it breaks #345118: Performance: Split .module files by moving hooks.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| drupal-error.patch | 14.59 KB | Idle | Failed: 11286 passes, 10 fails, 0 exceptions | View details |
Comments
#1
#2
I need help here, because I have no clue why the tests are failing.
#3
The last submitted patch failed testing.
#4
Looks like callback & function names mismatched in error_test.module, and the module was returning "page not found" instead of actual error information.
re-rolled with matching callback/function names
#5
Dear testbot, please mark as RTBC if the patch comes back clean.
#6
The last submitted patch failed testing.
#7
Some additional mismatched names in assertions & paths (system_test_* instead of error_test_*), which I missed because I only ran the system tests, not the simpletest tests.
re-rolled.
#8
Yay! Awesome! Thank you, mr.baileys!
#9
Cool. Committed to HEAD!
#10
Automatically closed -- issue fixed for 2 weeks with no activity.