Drupal 6.12., XMLsitemap 6.x-2.x-dev of May 22 2009, enabled xmlsitemap and xmlsitemap node.
- I installed this dev version of today after deinstalling the previous dev. version -

Get the following error message when rebuilding the xml sitemap in the latest dev version:
warning: Missing argument 1 for xmlsitemap_node_xmlsitemap_links_batch_info() in /home/..../domains/...../public_html/..../sites/all/modules/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module on line 170.

Result of rebuilding the sitemap is a sitemap with only a priority setting for the homepage, priority settings for rest of the nodes is left blank (in the previous dev. version this was 0, which should be 0.5 ?) .
When looking at the xmlsitemap table I see that the priority settings for the corresponding nodes have not been populated, e.g. have a value of 'NULL'

I realise this is a development version, however I did not have this error in the previous 6.x-2.x-dev, therefore this bug report.

Regards,
Enno

Comments

avpaderno’s picture

Title: error message: missing argument on line 170 » Missing argument for xmlsitemap_node_xmlsitemap_links_batch_info()
dave reid’s picture

Status: Active » Fixed

Thanks for the bug report. I've fixed the error message you received in http://drupal.org/cvs?commit=215108 and will be included in the next build.

As far as the node proirties, the sitemap.org specification says that if a priority value is not provided, it is assumed to be a default value of 0.5. So this is intentional and helps save filespace/time by not including the priority value when it is the default.

I hope this answers your questions Enno!

Anonymous’s picture

Dave,

yes it does answer my question. Omitting the priority value for 'non-front-nodes' is indeed a filespace/time saver for 'XL-websites'.

Thanx for your help!

Consider matter closed...

Anonymous’s picture

Status: Fixed » Closed (fixed)

I mean closed....

dave reid’s picture

Status: Closed (fixed) » Fixed

@Enno: Go ahead and just leave it as fixed. That way others can still find the issue if they have the problem (which isn't likely at this point, but you never know). When an issue is marked closed you don't see it by default in the issue listings.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.