Mark all read needs to use changed date, not created date of node
Michelle - May 22, 2009 - 15:13
| Project: | Advanced Forum |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
While testing the pgsql patch I discovered that the current MAR functionality misses some posts on my dev site. Need to investigate.
Michelle
#1
Bumping to development branch. Will backport when it's fixed.
Michelle
#2
The likely culprit:
[12:51] I will note that mark as read compares node.created and Views, at least, compares node.changed
[12:51] So with this query I think a node with a very old created and a more recent changed might get marked unread because its history record would get deleted and no one one might get added.
#3
Here's the patch for testing - thanks to merlinofchaos for getting to the root of this one
#4
I reviewed this enough to test that it didn't break MAR but I didn't set up the edge case the fix targetted. Going to call this fixed. If I (or anyone) run into any more weirdness, I'll re-open.
Thanks,
Michelle
#5
seems to be working for me.
#6
#7
hi,
is this fix in the current dev version of advanced forums? my users are running into this issue.
Thanks!
dave
#8
It's fixed in 2.x. I haven't backported it to 1.x. I suppose I could do that. It's a small enough thing.
Michelle
#9
well, what do you suggest? I could either upgrade to 2.x-dev or use the 1.x-dev (if you want to port it), or finally, if you give me the fix I could just put it into my current code base (if it isn't too complicated).
#10
The fix is in #3. No, I don't recommend upgrading to 2.x. I'll get it into the 1.x dev eventually. This is a weird edge case thing that rarely happens so it hasn't been a super high priority for me.
Michelle
#11
thanks, michelle. guess i didn't look close enough to the thread. sorry about that!
#12
well, i noticed this works when i am at a forum page (viewing just topics for a forum). But, when i try to mark all read from a container page (containing multiple forums), it doesn't seem to work. am i missing something?
#13
Containers can't have posts in them so there would be nothing to mark read. Being able to mark all forums in a container all read at once would be a new feature request. The code isn't designed to handle that, and that's unrelated to this issue.
Michelle
#14
oh ok, i guess i'll just make it so the button doesn't show up in containers.
#15
Fixing title so I remember what this is.
Michelle
#16
Ok, backported to both 1.x and D5.
Michelle
#17
Automatically closed -- issue fixed for 2 weeks with no activity.