1. Added variable deletion to the uninstall function.
2. added a check_markup to the message body, and also increased its truncation limit to 400 characters as that does not seem to cause any problems.
A couple of other issues:
1. I am using Firefox 3.5b4, so this bug may be in there, but I have added a screenshot to show how the last character of every line has its end chopped off - I doubt anything can be done, but I am just mentioning it.
2. It would also be appreciated if the default title gonf size can be larger - however once again, this may not be in the scope of this module as it is set in the css downloaded with the jquery plugin. (I am not a big fan of the drupal policy of not allowing the upload of "foreign" files... makes things that should be one step into two or more... but policy is policy.)
(also, instead of point releases, you may consider making dev releases which will automatically update every 12 hours if there have been updates.)
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | pmgrowl.patch | 2.07 KB | naheemsays |
| pmgrowl.patch | 1.37 KB | naheemsays | |
| pmgrowl_notification.png | 29.45 KB | naheemsays |
Comments
Comment #1
naheemsays commentedupdated patch - moved the pmgrowl settings page as a tag of the privatemsg settings and renamed the title to growl notifications.
Not too bothered about the name etc, but the location is IMO better.
Comment #2
naheemsays commentedComment #3
Dave.Ingram commentedLooks great, thanks. Patch committed. As for the line being cut off, could you try switching your theme? There must be something with a padding, margin, or width in your css that's conflicting with the jgrowl.css. I wouldn't think that it's a problem with Firefox, but you never know.. have you pointed Firebug at it yet to see what's going on with the styles in there?
Comment #4
naheemsays commentedIt's the same on garland, so probably a unreleased-firefox-beta bug.
Thanks for committing the patch too.
Comment #5
Dave.Ingram commentedAlright. If you find it's something with the module, please open up a new issue. The patch is in, so I'm going to go ahead and mark this one as closed. Thanks again for the patch!