in eventblock.js, blockUpdater.prototype.update uses in incorrect variable to set the element html, it uses "result" when it should use "xmlHttp.responseText", attached is a patch to fix that. It was done by another programmer at my company and i reviewed it, so it should be good to merge in. The patch is done against the latest 5.x-1.x-dev.

CommentFileSizeAuthor
#2 eventblock.patch5.86 KBsnufkin
#1 eventblock.patch0 bytessnufkin
event-block.patch742 bytessmccabe

Comments

snufkin’s picture

snufkin commented
StatusFileSize
new eventblock.patch0 bytes

I can confirm that this functionality is indeed broken, the patch fixes it. Rerolled vs CVS because it was rolled the other way around.

The opening patch fixes the issue by
a) referencing the self object, so variables stored in the instance are accessable, thus abort is working
b) from the ajax response "result" variable contains the returned HTML, not xmlHttp (thats actually the return status as far I understood).

Also removed the windows newlines.

snufkin’s picture

snufkin commented
StatusFileSize
new eventblock.patch5.86 KB
gerhard killesreiter’s picture

gerhard killesreiter commented
Status: Reviewed & tested by the community » Fixed

thanks, applied!

smccabe’s picture

smccabe commented

Awesome, and thanks for fixing up the patch snufkin.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.