add drupal 6.x support

vectoroc - May 22, 2009 - 22:26
Project:Htmltidy
Version:6.x-1.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Looks like this module made for drupal 5.x

#1

vectoroc - May 23, 2009 - 01:09
Status:active» needs review

Its work for me. Need some testing.

AttachmentSize
htmltidy.patch 4.01 KB

#2

jubalkessler - July 21, 2009 - 20:33

Got this when running the latest version (6.x-1.0):

warning: Missing argument 1 for htmltidy_menu() in /sites/museum/modules/htmltidy/htmltidy.module on line 34.

Seems to be part of this patch.

Suggestions?

#3

michaelfavia - July 21, 2009 - 21:11

will look at and commit tomorrow for you.

#4

Jax - August 20, 2009 - 12:32
Status:needs review» needs work

The hook_menu is implemented as it was in D5. That should be removed from the patch.

#5

lavamind - August 23, 2009 - 18:18

Reverting the menu makes the error message go away, but the module doesn't work at all for me, using Drupal 6.13. I see "Array" on top of all my pages when the filter is active, and filtered node content doesn't appear.

#6

vectoroc - September 5, 2009 - 12:13

wrong patсh
there is patсh which make my fixed file to old original :)
sorry for mistake

AttachmentSize
htmltidy.patch 4.1 KB

#7

vectoroc - September 5, 2009 - 12:21
Status:needs work» needs review

I use that through monkey path. At begin of page.tpl insert ob_start(), at end - print htmltidy_string( ob_get_clean() )

#8

vectoroc - September 5, 2009 - 13:47

There is new path which supports drupal 6.x filters

AttachmentSize
htmltidy.patch 7.2 KB

#9

vectoroc - September 5, 2009 - 15:39

I found bug in patch. There is fixed.

AttachmentSize
htmltidy.patch 7.23 KB

#10

jsgammato - September 14, 2009 - 19:34

Is there a way for a non-developer user to use this patch? Or do we have to wait for a build?
I don't mind carefully copying and pasting code, but that's about the limit of my skill!

#11

vectoroc - September 20, 2009 - 22:25

#12

glass.dimly - October 5, 2009 - 21:45
Category:feature request» bug report

Hi folks,

I'm changing this to a bug report. It's obviously critical because it impairs the module from functioning without the application of a patch.

Can someone with commit access roll this into a release?

thanks,
glass.dimly

#13

glass.dimly - October 5, 2009 - 22:41

This patch doesn't fully add D6 support.

It eliminates the above error, but navigating to admin/settings/htmltidy still produces no configuration page. Copying the htmltidy library to modules/htmltidy/bin likewise has no effect on the module configuration page.

There is an HTMLtidy input filter, but has no configuration options.

It's a great thing to release a module that is still in development, but please use the "dev" release so that you don't "break the Drupal" of unsuspecting newbies.

#14

vectoroc - October 10, 2009 - 21:10

did you enable a module through drush? Try to reenable htmltidy from admin/build/modules.
http://skitch.com/vectoroc/nnica/html-tidy-tree.local

#15

glass.dimly - October 12, 2009 - 01:07
Priority:critical» normal

I did enable it through Drush.

You're right, when I just now enabled it normally, it did display configuration pages. I'm moving this bug back down to normal and will let others take it from here.

I was using HTML Tidy to fix a bug in WYSIWYG, but I ended up switching from WYSIWYG to FCKeditor, so I don't really need Tidy for the moment, but thanks for taking to time to respond to my post.

#16

michaelfavia - October 12, 2009 - 02:11
Status:needs review» fixed

D6 support was fully integrated into the dev branch for d6 in CVS but i failed to make a release node for it. I apologize for that it was my mistake. I have posted it on the porject page now and will happily accept patches for improvement. ill be available in IRC this week if anyone needs me or just opena new issue with specific concerns on the project page.

#17

System Message - October 26, 2009 - 02:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.