add drupal 6.x support
vectoroc - May 22, 2009 - 22:26
| Project: | Htmltidy |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Looks like this module made for drupal 5.x
| Project: | Htmltidy |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Looks like this module made for drupal 5.x
#1
Its work for me. Need some testing.
#2
Got this when running the latest version (6.x-1.0):
warning: Missing argument 1 for htmltidy_menu() in /sites/museum/modules/htmltidy/htmltidy.module on line 34.
Seems to be part of this patch.
Suggestions?
#3
will look at and commit tomorrow for you.
#4
The hook_menu is implemented as it was in D5. That should be removed from the patch.
#5
Reverting the menu makes the error message go away, but the module doesn't work at all for me, using Drupal 6.13. I see "Array" on top of all my pages when the filter is active, and filtered node content doesn't appear.
#6
wrong patсh
there is patсh which make my fixed file to old original :)
sorry for mistake
#7
I use that through monkey path. At begin of page.tpl insert ob_start(), at end - print htmltidy_string( ob_get_clean() )
#8
There is new path which supports drupal 6.x filters
#9
I found bug in patch. There is fixed.
#10
Is there a way for a non-developer user to use this patch? Or do we have to wait for a build?
I don't mind carefully copying and pasting code, but that's about the limit of my skill!
#11
http://drupal.org/patch/apply
It is simple ;)
#12
Hi folks,
I'm changing this to a bug report. It's obviously critical because it impairs the module from functioning without the application of a patch.
Can someone with commit access roll this into a release?
thanks,
glass.dimly
#13
This patch doesn't fully add D6 support.
It eliminates the above error, but navigating to admin/settings/htmltidy still produces no configuration page. Copying the htmltidy library to modules/htmltidy/bin likewise has no effect on the module configuration page.
There is an HTMLtidy input filter, but has no configuration options.
It's a great thing to release a module that is still in development, but please use the "dev" release so that you don't "break the Drupal" of unsuspecting newbies.
#14
did you enable a module through drush? Try to reenable htmltidy from admin/build/modules.
http://skitch.com/vectoroc/nnica/html-tidy-tree.local
#15
I did enable it through Drush.
You're right, when I just now enabled it normally, it did display configuration pages. I'm moving this bug back down to normal and will let others take it from here.
I was using HTML Tidy to fix a bug in WYSIWYG, but I ended up switching from WYSIWYG to FCKeditor, so I don't really need Tidy for the moment, but thanks for taking to time to respond to my post.
#16
D6 support was fully integrated into the dev branch for d6 in CVS but i failed to make a release node for it. I apologize for that it was my mistake. I have posted it on the porject page now and will happily accept patches for improvement. ill be available in IRC this week if anyone needs me or just opena new issue with specific concerns on the project page.
#17
Automatically closed -- issue fixed for 2 weeks with no activity.