Translatable strings review

I will ask to my English counselor about the different English sentences proposed, which seems to have a slightly different meaning.

Only a note about invalid: there are no differences between not valid, and invalid, except that invalid also means a person made weak or disabled by illness or injury. This is personal preference, and I prefer to use not valid.

Invalid for most English speakers means not valid. We very rarely use or hear the connotation for a weak person.

Thanks for your contribution with this.

As you speak English as first language, do you see any differences (even if nuances) between there are no settings currently defined, and there are currently no settings defined? Or is it one grammatically correct, and one is not correct?

The definition I reported for invalid is the definition given in the New Oxford American Dictionary. If even the word would be interpreted as only meaning not valid, the path is not valid is still understood, it's grammatically correct, it's not jargon, nor it's slang. Without a valid reason to change it, I don't see why it should be changed.

In Drupal core, http://api.drupal.org/api/function/path_admin_form_validate/6 uses t("The path '@link_path' is either invalid or you do not have access to it."); so I'd say it's ok to use. I'll look over the rest of the changes.

The task has been partially completed.

There is another string I am not going to change. Apply cannot be changed to Save because it is used on a form where there is nothing to be save, but an operation is being applied.

So far, there is just a string that could need to be changed.

BTW, there is an error with an extra single quote in the change you just made: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/....

Drupal core uses t("The path '@link_path' is either invalid or you do not have access to it.")

In that case, I should adopt the same string, but I am not going to use The path is invalid..

Also, in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/..., you should not use 'The priority of a link determinates its position in the sitemap; the links with a higher priority will appear first in the sitemap.' as determinates is not an english word. Please use determines.

I always confuse the adjective determinate with the verb to determine. It must be because in my language the adjective determinate doesn't exist; the word we use is the past particle of to determine (determinate comes from the Latin word that is the past participle of the Latin equivalent for to determine).

Anyway, thanks for reporting what was wrong in the commits I made; your help is well appreciated.

Kiam, no problem. Just so you know, you just changed 'determinates' to 'determinetes' which is still wrong. It should be 'determines'.
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...

I noticed there is something wrong in the files I locally have; I have fixed a problem with extra apices, but I still see a syntax error about that, which I fixed before.

Thanks for the clarification, earnie.

I changed that string, and used the equivalent of the string used by Drupal.
Now, the only string left is there are no settings currently defined that is equivalent to there are currently no settings defined. I asked to my English advisor, and she told me that. Being this the case, I am not going to change that string.

The task should be considerate concluded, but I will leave it open, in the case I missed something.

I find hard to propose a different string used in a form button without to even see the relative form, and understand the context.
That form simply applies an operation that is selected by the user; it doesn't save anything. I find that save referred to an operation like submit the sitemap to the search engines sounds quite a little incorrect.

I am going to change the status of the report. If there is something else to change, feel free to reopen it.
Please, reopen it for really necessary changes that are motivated; don't open it to report a change from you and me to me and you, in example.

The first change from using "when" to using "if" doesn't correct anything, but it's just a style preference. I personally prefer "you can change the priority when you edit the taxonomy term", in example; it would be better to let who speaks English as first language decide about what is the best way of express that thought.

The other strings proposed to change are the strings that appear in the update log, which list the SQL queries made from the updates; that is the reason I used strings that would appear similar to SQL queries, even if it's evident that they are not SQL queries.
Those strings could also be removed; I used them just because I think an update function should leave a track of what it did, even if it didn't execute any SQL queries. As that is my personal preference, I would let earnie decide about that.

To add a thought more, I think that "you can change the priority if you edit the taxonomy term" has a different meaning than "you can change the priority when you edit the taxonomy term" (I know the sentence is not exactly that, but that doesn't change what I am going to say).
The proposed change has the same effect of changing "you and me" with "me and you"; who uses "you and me" could put the accent on "you", but in general "you and me" is seen equivalent to "me and you" (without a particular context associated with the nominal phrase).

"The default priority may be changed while adding or editing a vocabulary and the default priority can be overridden while adding or editing terms."

"changed" is better than "assigned". The default priority is already assigned, and "changed" describes better what the user is doing; "assigned" would mean there isn't a default value used.

That is even better.

If that is the full string, it would be enough to not use the " delimiters for the string, to avoid the need of escaping the same character inside the string.