Patch attached with a few corrections.

Comments

avpaderno’s picture

Category: task » bug
Status: Active » Postponed

I will ask to my English counselor about the different English sentences proposed, which seems to have a slightly different meaning.

Only a note about invalid: there are no differences between not valid, and invalid, except that invalid also means a person made weak or disabled by illness or injury. This is personal preference, and I prefer to use not valid.

dave reid’s picture

Status: Needs review » Postponed

Invalid for most English speakers means not valid. We very rarely use or hear the connotation for a weak person.

avpaderno’s picture

Thanks for your contribution with this.

As you speak English as first language, do you see any differences (even if nuances) between there are no settings currently defined, and there are currently no settings defined? Or is it one grammatically correct, and one is not correct?

The definition I reported for invalid is the definition given in the New Oxford American Dictionary. If even the word would be interpreted as only meaning not valid, the path is not valid is still understood, it's grammatically correct, it's not jargon, nor it's slang. Without a valid reason to change it, I don't see why it should be changed.

dave reid’s picture

In Drupal core, http://api.drupal.org/api/function/path_admin_form_validate/6 uses t("The path '@link_path' is either invalid or you do not have access to it."); so I'd say it's ok to use. I'll look over the rest of the changes.

avpaderno’s picture

Category: bug » task

The task has been partially completed.

There is another string I am not going to change. Apply cannot be changed to Save because it is used on a form where there is nothing to be save, but an operation is being applied.

So far, there is just a string that could need to be changed.

dave reid’s picture

BTW, there is an error with an extra single quote in the change you just made: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/....

avpaderno’s picture

Drupal core uses t("The path '@link_path' is either invalid or you do not have access to it.")

In that case, I should adopt the same string, but I am not going to use The path is invalid..

dave reid’s picture

Also, in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/..., you should not use 'The priority of a link determinates its position in the sitemap; the links with a higher priority will appear first in the sitemap.' as determinates is not an english word. Please use determines.

avpaderno’s picture

I always confuse the adjective determinate with the verb to determine. It must be because in my language the adjective determinate doesn't exist; the word we use is the past particle of to determine (determinate comes from the Latin word that is the past participle of the Latin equivalent for to determine).

Anyway, thanks for reporting what was wrong in the commits I made; your help is well appreciated.

dave reid’s picture

Kiam, no problem. Just so you know, you just changed 'determinates' to 'determinetes' which is still wrong. It should be 'determines'.
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/xmlsitemap/...

avpaderno’s picture

I noticed there is something wrong in the files I locally have; I have fixed a problem with extra apices, but I still see a syntax error about that, which I fixed before.

Anonymous’s picture

except that /invalid/ also means /a person made weak or disabled by illness or injury/. This is personal preference, and I prefer to use /not valid/.

The inflections of the voice are different for the two. I'm not sure how to describe it. The a is softer for the made weak definition and the lid is stronger with the l belonging more to lid. The not valid definition the a is stronger and the l leans toward val. The syllables are more in-val-id for the not valid definition and in-va-lid for the made weak definition.

HTH

avpaderno’s picture

Status: Needs work » Active

Thanks for the clarification, earnie.

I changed that string, and used the equivalent of the string used by Drupal.
Now, the only string left is there are no settings currently defined that is equivalent to there are currently no settings defined. I asked to my English advisor, and she told me that. Being this the case, I am not going to change that string.

The task should be considerate concluded, but I will leave it open, in the case I missed something.

hass’s picture

Status: Postponed » Active

Doesn't Apply save a configuration setting in the database? Sorry I haven't taken a look to the UI about this. If "apply" save settings with ajax without reloading the page it's ok, but it would be the first Drupal page we have used "apply". Their is no "Apply" string in core or any other module I have installed except views... "Save" is always used.

avpaderno’s picture

I find hard to propose a different string used in a form button without to even see the relative form, and understand the context.
That form simply applies an operation that is selected by the user; it doesn't save anything. I find that save referred to an operation like submit the sitemap to the search engines sounds quite a little incorrect.

avpaderno’s picture

Status: Active » Fixed

I am going to change the status of the report. If there is something else to change, feel free to reopen it.
Please, reopen it for really necessary changes that are motivated; don't open it to report a change from you and me to me and you, in example.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hass’s picture

Status: Closed (fixed) » Needs review

May needs a re-role/re-apply for beta0 rollback

Anonymous’s picture

Status: Needs review » Active

Changing the status properly.

If you've suggestions, please let me know ASAP. I will mark a string freeze shortly after the BETA6 release.

hass’s picture

Have you fixed all the buggy strings in the above patch? Why have you changed to active?

Anonymous’s picture

Status: Active » Needs work
hass’s picture

Category: bug » task
Status: Postponed » Needs work

Seems like I need to review all again... :-( or are you going to commit more other patches still missing?

hass’s picture

Assigned: Unassigned »

Please do not commit big patches... I provide a patch asap.

hass’s picture

Status: Needs work » Needs review
StatusFileSize
new11.58 KB

New patch attached.

avpaderno’s picture

Status: Needs review » Needs work

The first change from using "when" to using "if" doesn't correct anything, but it's just a style preference. I personally prefer "you can change the priority when you edit the taxonomy term", in example; it would be better to let who speaks English as first language decide about what is the best way of express that thought.

The other strings proposed to change are the strings that appear in the update log, which list the SQL queries made from the updates; that is the reason I used strings that would appear similar to SQL queries, even if it's evident that they are not SQL queries.
Those strings could also be removed; I used them just because I think an update function should leave a track of what it did, even if it didn't execute any SQL queries. As that is my personal preference, I would let earnie decide about that.

avpaderno’s picture

To add a thought more, I think that "you can change the priority if you edit the taxonomy term" has a different meaning than "you can change the priority when you edit the taxonomy term" (I know the sentence is not exactly that, but that doesn't change what I am going to say).
The proposed change has the same effect of changing "you and me" with "me and you"; who uses "you and me" could put the accent on "you", but in general "you and me" is seen equivalent to "me and you" (without a particular context associated with the nominal phrase).

Anonymous’s picture

Status: Needs work » Needs review

You can change the default priority if you add or edit a vocabulary, and you can override the default priority if you add or edit individual terms.

How about:

The default priority may be changed while adding or editing a vocabulary and the default priority can be overridden while adding or editing terms.

EDIT: Or instead of ``changed'' how about ``assigned''?

avpaderno’s picture

"The default priority may be changed while adding or editing a vocabulary and the default priority can be overridden while adding or editing terms."

"changed" is better than "assigned". The default priority is already assigned, and "changed" describes better what the user is doing; "assigned" would mean there isn't a default value used.

Anonymous’s picture

I like

The term default priority may be changed while adding or editing vocabularies and the term default priority can be overridden while adding or editing terms.

better. The added "term" adds clarity to the sentence. Modifying "a vocabulary" to vocabularies uses the same plurality found later in the sentence with "terms".

avpaderno’s picture

Status: Needs review » Reviewed & tested by the community

That is even better.

Anonymous’s picture

Status: Reviewed & tested by the community » Active

Committed to CVS.

I've set this back to active for a later review.

hass’s picture

Status: Active » Needs review
StatusFileSize
new3.65 KB

@earnie: I found a few more strings that should be changed... patch attached.

Anonymous’s picture

Status: Needs review » Active

I've committed the #32 patch. Leaving open for further string review.

Anonymous’s picture

Status: Active » Fixed

I am considering this issue fixed and will open a string freeze issue.

hass’s picture

Status: Fixed » Active

There has been a bug introduced somewhere: The sitemap is located at <a href=\\\"@sitemap\\\">@sitemap</a>. have to many backslashes.

avpaderno’s picture

If that is the full string, it would be enough to not use the " delimiters for the string, to avoid the need of escaping the same character inside the string.

hass’s picture

Yes, the above is the extracted string. Escaped double quotes in PO files normally show \" in PoEdit.

Anonymous’s picture

Status: Active » Needs review
StatusFileSize
new872 bytes

The bug only exists in the xmlsitemap.pot and xmlsitemap.de.po files and not the original text. But I modified the text to remove the unneeded \.

Anonymous’s picture

Status: Needs review » Fixed

Change committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.