Compatibility with PHp5.2 version - Call By reference in question.install file

Posted by inders on May 24, 2009 at 5:51am

Issue Summary

Just tested this dev version of module and got:-

Warning: Call-time pass-by-reference has been deprecated in E:\mysite\indiapoly\sites\all\modules\question\question.install on line 38

Warning: Call-time pass-by-reference has been deprecated in E:\mysite\indiapoly\sites\all\modules\question\question.install on line 39

Warning: Call-time pass-by-reference has been deprecated in E:\mysite\indiapoly\sites\all\modules\question\question.install on line 45

Found:-Line 45 question.install

db_drop_primary_key(&$ret, 'question_queue');

Should be:-

db_drop_primary_key($ret, 'question_queue');

And found:-Line 38,39 question.install

db_add_primary_key(&$ret, 'question_node', array('nid'));
 db_add_primary_key(&$ret, 'question_queue', array('qid'));

Should be:-

db_add_primary_key($ret, 'question_node', array('nid'));
  db_add_primary_key($ret, 'question_queue', array('qid'));

Posted by tanoshimi on March 30, 2010 at 6:16pm

Assigned to:

inders

» tanoshimi

Attached in patch format.

Attachment	Size
question_471324_passbyref.patch	873 bytes

Posted by tanoshimi on April 4, 2010 at 8:08pm

Status:

needs review

» fixed

Committed to 6.x-1.x-dev branch.

Posted by System Message on April 18, 2010 at 8:10pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.