Hi QS,

I came across several errors when i tried to export/import new translations for the webform module. Beneath are the errors i got. Most are probably easy to solve. I'll be happy to translate again after solving these little issues. I'll post the new translation file for Dutch users in a separate post to keep things clear. Hope this helps. Regards,

Gert

Error mesages i got:

* The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($component['type']) in webform_components.inc on line 191.
* The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($component['type']) in webform_components.inc on line 271.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('webform',$message) in webform_report.inc on line 295.
* The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($c['name']) in webform.module on line 570.
* The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($file->name) in webform.module on line 2404.
* The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($file->name) in webform.module on line 2407.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('webform','Possible spam attempt from @remote_addr'."
\n".nl2br(htmlentities($messages['default'])),array('@remote_add'=>ip_address())) in webform.module on line 1839.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('webform',t('Submission posted to %title. Results. !details',array('%title'=>$node->title,'!url'=>url('node/'.$node->nid.'/submission/'.$sid),'!results'=>"
\n

".htmlentities(print_r($form_state['values'],TRUE)).'

'))) in webform.module on line 1878.
* Invalid menu 'description' definition found in webform_menu(). Title and description keys of the menu array should be literal strings. In webform.module on line 74.
* Invalid menu 'description' definition found in webform_menu(). Title and description keys of the menu array should be literal strings. In webform.module on line 85.

Comments

quicksketch’s picture

As far as I know, these problems have all been solved in one way or another. Previously we were translating a lot of component type names based on the file name. This has been fixed in the 3.x version, though the change won't be included in the 2.x version because it required an API change (see #340241: Provide hook_webform_component_info() to allow 3rd-party components). t() has been removed from hook_menu() in the 2.7 version I believe. Please file an issue for individual problems if this persists in the 3.x version.

quicksketch’s picture

Status: Active » Closed (fixed)