RTL support for nice-menus

elcuco - May 24, 2009 - 11:31
Project:Nice Menus
Version:6.x-2.x-dev
Component:CSS
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Issue tags:RTL
Description

The attached patch adds RTL support for nice menus. Please test, verify, and make my life easier :)

AttachmentSize
fix-nice-menus-rtl.patch5.11 KB

#1

add1sun - May 24, 2009 - 12:01

Is this working off of the old issue where the base RTL went in? #181446: RTL‌ direction support

#2

elcuco - May 24, 2009 - 12:24

The old thread is just rants about people. Nobody actually did anything useful. This patch adds /* LTR */ comments to the base css, and adds RTL css to the two styles. With this patch the sub-menus are opened to the correct direction.

Lets wait for the community to test (I posted at drupal.org.il about this issue).

#3

add1sun - May 24, 2009 - 12:34
Version:6.x-1.3» 6.x-2.x-dev

Right, but the point is that most of that code is already in the 6.x-2.x branch, so this patch will conflict. Please try out the dev version and write a patch against that if it isn't working properly.

#4

mikew_is - July 7, 2009 - 03:54

Hi I have been looking for exactly this for the past week, as I am relatively new to drupal, I have tried copying the code "as-is" into a file callednice_menus_default-rtl.css and put that file in the /modules/nice_menus/ directory, however when I change to hebrew the nice_menu is staying on the left and Primary Links that have child menus are disappearing.

1. Is this code working with drupal-6.13 ?
2. Where do I need to put the code ? i.e. in what directory
3. Do I need to edit the code in anyway to get it to work ?

Thanks for any help...

#5

elcuco - July 7, 2009 - 05:52

Mike,

this is a patch, not a file.

In *nix you do:

cd sites/all/modules/nice_menus
cat fix-nice-menus-rtl.patch | patch -p0 -- dry-run

If the last command works, remove the --dry-run at the end. Note that this patch is not against drupal-core, but against the nice menus module.

#6

mikew_is - July 7, 2009 - 12:34

Hi,

Thanks for the quick response. It works great!!
The only issue I have is when I switch language to hebrew I am still getting the Contact Us menu link both in English, Spanish & Hebrew - but basically the rest is working great - once again thank you!!!

I know this is not related to this issue, but on the english version of nice_menus I have bullets behind the text - any idea how to get rid of this ?

Regards,

Mike

#7

hamzah.qawasmi - July 11, 2009 - 20:45

how to apply this patch on windows ?

#8

mikew_is - July 12, 2009 - 11:27

After hours of searching, and I literally mean hours, I found how to get rid of the bullets - I needed to change the css file in my theme.
Other issue still open

#9

elcuco - July 12, 2009 - 14:41

hamzah.qawasmi
Here is a patch utility for windows, please don't continue this problem here. If you still need help, please open a thread in one of the groups, not in this issue.
http://gnuwin32.sourceforge.net/packages/patch.htm

mikew_is,
what is the the second issue?

#10

add1sun - July 12, 2009 - 14:53
Category:bug report» feature request
Status:needs review» needs work

Setting this to needs work because the patch needs to go against the 6.x-2.x-dev version, where a lot of these changes are already in.

#11

mikew_is - July 13, 2009 - 07:05

Hi elcuco

My escond issue, is actually the first one I mentioned :-):
My issue is that the "Contact Us" is now showing in primary links in all languages, so basically I have primary menu in english, but then have "Contact us" in hebrew and in Spanish there as well.

Thanks,

#12

Amir Simantov - October 5, 2009 - 13:05

I am using 6.x-2.1 but added the nice_menus_default-rtl.css file from 2.x-dev.

What I would like to do is to make a small menu which will work for ltr - that is, leaving all menus rtl but this one. So, I made 2 menus:

#block-nice_menus-1{float:right;width:70%;}/*rtl*/ /*width is for ie*/
#block-nice_menus-2{float:left;width:10%;}/*ltr*/ /*width is for ie*/
ul#nice-menu-2.nice-menu-down li.menuparent{float:left;background-position:right center;padding-right:15px;
text-align:left;}

However, something is still missing... I don't know how to fix (actually move the rtl-fix) for the hovering feature. Sub-items of parent are displayed with their right edge under the parent's one, instead of the left edge.

Any help will be much appreciated.

Thanks!

 
 

Drupal is a registered trademark of Dries Buytaert.