The pmgrowl.js file has the following code:

        $(alreadyGrowled).each(function(index, thread_id) {
          if(entry['thread_id'] == thread_id) {
            newMessage = false;
          }
        });

That only allows a single notification per thread. Maybe it should be made per mid? Otherwise if a page has had a notification of one message, where it has then been opened by opening the link in a new tab, further notifications are not recieved.

Also

  $query .= 'ORDER BY m.timestamp DESC';

Should that not be Ascending, to show notifications of messages "in order"?

Comments

Dave.Ingram’s picture

Dave.Ingram commented

Hi there, yes both sound reasonable. I went ahead and changed thread_id to mid and also switched the sort. I don't have time to test it out this afternoon, but went ahead and updated HEAD. If you have a chance to check it out, please do and let me know. Otherwise I'll have more time for it tomorrow.

Thanks again!

naheemsays’s picture

naheemsays commented
Status: Active » Fixed

Yes that works - Thanks!

Dave.Ingram’s picture

Dave.Ingram commented

Great! Let me know if there's anything else you see that needs improvement. If I don't hear of anything or find out anything else I'll start considering an official release. Any other feature requests? (besides the quick reply).

naheemsays’s picture

naheemsays commented

None that I can think of, but it might be a good idea to let others know on irc and test the module and give their assessments.

Dave.Ingram’s picture

Dave.Ingram commented
Status: Fixed » Closed (fixed)

Alright, thanks! Marking this one closed