When I try to make clean setup the last step is broken!

Because validation and submit handlers trying to retrieve data from $form_state['values']['account'] which is never found

CommentFileSizeAuthor
install-account.patch1.39 KBandypost

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Needs tests

Well then we definitely need tests for this, because Testing Bot is happily passing atm.

But could you post steps for how to reproduce this problem?

Status: Needs review » Needs work

The last submitted patch failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented

How to write test case if install.php is broken?

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

Right now all testing bots say for all issues Failed: Failed to install HEAD

Because there's no possibility to install drupal at all

andypost’s picture

andypost
he/him
Primary language Russian
commented

This one caused by #471234: Installer: Configure site text cleanup

- $form['admin_account']['account']['#tree'] = TRUE;

grendzy’s picture

grendzy commented

Steps to reproduce: install drupal. ;-)

The patch resolved it for me, though I haven't reviewed the code. This is the error without the patch:

  • Notice: Undefined index: account in install_configure_form_validate() (line 1123 of Sites/7-drupal/drupal/install.php).
  • You must enter a username.
  • Notice: Undefined index: account in install_configure_form_validate() (line 1126 of /Sites/7-drupal/drupal/install.php).
  • You must enter an e-mail address.
  • All necessary changes to ./sites/default and ./sites/default/settings.php have been made, so you should remove write permissions to them now in order to avoid security risks. If you are unsure how to do so, please consult the online handbook.
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Closed (duplicate)

Oh, son of a...! :\

Will fix in the other issue.