coder.drush.inc should declare coder as dependency

grendzy - May 25, 2009 - 03:12
Project:Coder
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

This tells drush that the coder module needs to be enabled in order to run the command.

AttachmentSize
coder_drush_dependencies.patch580 bytes

#2

dugh - August 1, 2009 - 16:22

Enabling the coder module doesn't make the drush error go away

#3

lambic - August 18, 2009 - 19:11

I encountered this today. I removed the call to t() to get drush working again (the patch didn't help).

Obviously removing the t() call isn't ideal, but I don't know how to fix it properly.

#4

John Morahan - August 28, 2009 - 09:23
Status:needs review» reviewed & tested by the community

That t() error is due to #455722: use of t() in coder.drush.inc line 10 should be replaced with dt() which is already fixed in dev.

This patch fixes a different bug which still exists even in dev: if you run 'drush coder' when coder is disabled, you get a fatal error about an undefined function, instead of a helpful drush message telling you to enable the module first.

Before:

Fatal error: Call to undefined function _coder_get_default_settings() in /home/john/public_html/coder/sites/all/modules/coder/coder.drush.inc on line 33

After:
Command coder needs the following modules installed/enabled to run:  [error]
coder.
The command 'drush coder' could not be executed.                     [error]

#5

stella - October 18, 2009 - 13:08
Status:reviewed & tested by the community» fixed

Committed to both 6.x-2.x-dev and 7.x-1.x-dev, thanks!

#6

System Message - November 1, 2009 - 13:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.