Download & Extend
Content Access » Issues

"Add/Revoke access for user" Rules action doesn't add the node to ACL

Posted by fearlsgroove on May 25, 2009 at 7:38pm
Project:Content Access
Version:6.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When using the rules action add access to user, the routine fetches (creates or loads) the acl and adds the user but doesn't add the node. The result is that the ACL doesn't apply to the node. Although the comments state:

    // A following node_save() updates the grants for us.

I assume this refers node_access getting rebuilt?

Attached patch adds the same acl_node_add_acl call as the admin form uses.

AttachmentSizeStatusTest resultOperations
content_access-rules-acl-node-fix.patch598 bytesIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by greg.harvey on June 5, 2009 at 4:36pm
Title:Rules Add access for user doesn't add node to acl» Rules Add/Revoke access for user doesn't add node to acl
Status:needs review» reviewed & tested by the community

Works for me. =)

#2

Posted by kiamlaluno on June 21, 2009 at 5:57am
Title:Rules Add/Revoke access for user doesn't add node to acl» "Add/Revoke access for user" Rules action doesn't add the node to ACL

I would expect the Rules action to call acl_node_add_acl() as the code for the settings page already does.

#3

Posted by fago on July 31, 2009 at 9:10am
Status:reviewed & tested by the community» fixed

You are right, committed, thanks!

#4

Posted by System Message on August 14, 2009 at 9:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here