Can't install on PostgreSQL [#472646]

The installer is failing immediately after db credentials with the follow error:

Failed to create a test table on your PostgreSQL database server with the command CREATE TABLE drupal_install_test (id int NULL). PostgreSQL reports the following message: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near ""UTF8""
LINE 1: SET NAMES "UTF8"
^.
- Are you sure the configured username has the necessary PostgreSQL permissions to create tables in the database?
For more help, see the Installation and upgrading handbook. If you are unsure what these terms mean you should probably contact your hosting provider.
Failed to insert a value into a test table on your PostgreSQL database server. We tried inserting a value with the command INSERT INTO drupal_install_test (id) VALUES (1) and PostgreSQL reported the following error: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near ""UTF8""
LINE 1: SET NAMES "UTF8"
^.
Failed to update a value in a test table on your PostgreSQL database server. We tried updating a value with the command UPDATE drupal_install_test SET id = 2 and PostgreSQL reported the following error: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near ""UTF8""
LINE 1: SET NAMES "UTF8"
^.
Failed to delete a value from a test table on your PostgreSQL database server. We tried deleting a value with the command DELETE FROM drupal_install_test and PostgreSQL reported the following error: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near ""UTF8""
LINE 1: SET NAMES "UTF8"
^.
Failed to drop a test table from your PostgreSQL database server. We tried dropping a table with the command DROP TABLE drupal_install_test and PostgreSQL reported the following error SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near ""UTF8""
LINE 1: SET NAMES "UTF8"
^.

Comment	File	Size	Author
#6	472646-corrent-syntax.patch	774 bytes	josh waihi
#1	472646-corrent-syntax.patch	787 bytes	josh waihi

Comments

Comment #1

josh waihi commented 25 May 2009 at 23:26

Status:

Active

» Reviewed & tested by the community

Status	File	Size
new	472646-corrent-syntax.patch	787 bytes

quick fix for this - Use syntax that postgreSQL likes. I've tested this. It works

Comment #2

josh waihi commented 25 May 2009 at 23:28

Issue tags:

+Quick fix

tagging as brain dead commit-able patch

Comment #3

mikey_p commented 25 May 2009 at 23:32

Confirming this fixed the error.

Comment #4

damien tournoud commented 25 May 2009 at 23:41

Erm. SET NAMES "UTF8" is listed as a valid syntax on [1].

Is that the double quotes that PostgreSQL dislike in the SET NAMES syntax? If so, why in hell does it accept it on SET client_encoding TO?

[1] http://www.postgresql.org/docs/8.3/static/multibyte.html

Comment #5

damien tournoud commented 25 May 2009 at 23:43

Status:

Reviewed & tested by the community

» Needs work

Well, I confirms that:

SET client_encoding TO "UTF8"; // Works
SET NAMES "UTF8"; // Fails

SET client_encoding TO 'UTF8'; // Works
SET NAMES 'UTF8'; // Works

If I believe the PostgreSQL manual, the version with single quotes is the preferred one. Let's use this one.

Comment #6

josh waihi commented 25 May 2009 at 23:53

Status:

Needs work

» Needs review

Status	File	Size
new	472646-corrent-syntax.patch	774 bytes

This seems to be an issue from #319165: postgresql explicit encoding set where the patch wasn't tested but commited instead. I've changed the quoting so the previous syntax works