Deletion warnings in APC

fgm - May 26, 2009 - 05:02
Project:Cache Router
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The current version of apcCache::delete loops on a possibly empty array.

This small patch is similar to the one applied for 1.1.2.13 in the D6 branch for this specific problem. It does not tackle the other apc issues, though.

#1

fgm - May 26, 2009 - 05:03

Grrr, missed patch attachment.

AttachmentSize
cacherouter.patch 1 KB

#2

alippai - August 25, 2009 - 14:45
Status:needs review» reviewed & tested by the community

I don't know, why apc_fetch return empty string - if we can drop theese strings this is RTBC.

EDIT, checking for &$success or for return false is not enough :/

#3

kscheirer - September 3, 2009 - 00:13

seeing this issue as well whenever we clear Drupal's cache, at least the patch will test for an array before foreach()ing.

warning: Invalid argument supplied for foreach() in sites/all/modules/cacherouter/engines/apc.php on line 121.

#4

slantview - September 3, 2009 - 06:39
Status:reviewed & tested by the community» fixed

This has already been fixed.

#5

System Message - September 17, 2009 - 06:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.