hi
I use links module in order to display links in some content types
I saw that the field displayed in the node creation/editing page doesn't allow to have url longer than 128. I don't have limit in the table, and the #maxlength of the $form['links_weblink_url'] is set to 512 (http://drupal.org/node/232575)
You can have a look to my website : http://www.lefermenteurabioreaction.com/biotech/grosse-acquisition-johns...
and see/follow the link "la suite de l'article"
Do you have any idea ?
Thanks for your module.
Ben

CommentFileSizeAuthor
#3 links_related_url_textfield_maxlength.patch471 byteszoen

Comments

bneel’s picture

bneel commented

up

bneel’s picture

bneel commented
Priority: Normal » Critical

This module is non usable if an URL longer than 128 is past. Without any answer since 3 weeks, I upgrade the priority to critical level.
Does somebody have an idea ?
Benjamin

zoen’s picture

zoen commented
StatusFileSize
new links_related_url_textfield_maxlength.patch471 bytes

Hi Benjamin,

I needed this fix too, so I created a patch, and here it is.

This patch just adds 1 line, after line 346 of links_related.module. It sets the max length of the Related Links URL textfield to 2048 characters. I couldn't figure out a way to make the field have no limit - it looks like when a maxlength isn't specified for a single-line textfield, Drupal (5 at least) automatically sets the maxlength to 128. I chose 2048 because that's the URL length limit of one of the major browsers (guess which browser has a wimpy max URL length like that? Fie on you, IE!!).

Do you have any feedback for me? This is only my second patch ever. :-)

damien_vancouver’s picture

damien_vancouver commented
Status: Active » Closed (won't fix)

Hmmm... it appears this fix was already committed to 5.x-1.x-dev, but there has been no release since then.

See the commit message here: http://drupal.org/cvs?commit=172200

Thus I'm marking this issue as "Won't Fix" because it is already fixed for now. Maybe it should be marked "Duplicate" but I'm not sure there's another issue covering this, it appears to just have been fixed at the same time as the fix for #156592.

That fix apparently turns it up the length to 512. Is 512 still too small? Does anyone know if there's an issue discussing this problem already? Someone (Benjamin?) should test this version see if it fixes their problem and report back on this thread.

@zoe, the patch looks good though!

@bneel, try downloading version 5.x-1.x-dev and see if that solves your problem, it should. It has some fixes including this one that aren't in the 5.x-1.2 release.

syscrusher’s picture

syscrusher commented
Assigned: Unassigned » syscrusher

Hi, sorry for the delay in this. I hope to get a fix with 2048 committed very soon, but was holding it pending another bug that is being fixed at the same time.

Scott