A user can remove a filter by using the "unclick" link provided in the Current search block. Adding a similar link for the search keys would be convenient and make the UI more consistent.
Of course, this only makes sense with the new capability provided by #358166: Search for just facet(s).

CommentFileSizeAuthor
#8 473554-8.patch1.11 KBjanusman
#4 473554_4.patch1.85 KBjanusman

Comments

janusman’s picture

janusman commented

I'm thinking this is rather trivial?

* Comment above a sad excuse for bumping this =) *

robertdouglass’s picture

robertdouglass commented

This is a nice little feature request that I'd still group in the 6-1--0 branch. Anyone want to take a first swing at rolling a patch?

janusman’s picture

janusman commented
Assigned: Unassigned » janusman

Taking this...

janusman’s picture

janusman commented
Status: Active » Needs review
StatusFileSize
new 473554_4.patch1.85 KB

Here be a patch.

Took some code from @aufumy's patch in http://drupal.org/node/270412#comment-1747426 to add the public function remove_keys() to Solr_base_query.php

robertdouglass’s picture

robertdouglass commented
Version: 6.x-1.x-dev » 6.x-2.x-dev

Let's resolve #545094: Method to set Keys on Query first and then get this in.

pwolanin’s picture

pwolanin commented

Per discussion w/ Janusman. I think we'll need to change the interface, so we should not put this on the 1.x branch where it would break existing integrations.

I think a set_keys() method is more generally useful, and it's not clear then that we need a remove_keys() method.

robertdouglass’s picture

robertdouglass commented
Status: Needs review » Needs work

There are now $query->get_keys() and $query->set_keys().

janusman’s picture

janusman commented
Status: Needs work » Needs review
StatusFileSize
new 473554-8.patch1.11 KB

New patch for latest DRUPAL-6--2.

robertdouglass’s picture

robertdouglass commented
Status: Needs review » Fixed

Thank you. Committed to 6.2.

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

Peter may want to port.

pwolanin’s picture

pwolanin commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Fixed

If I understand, this requres the interface changes, so we were not going to backport.

robertdouglass’s picture

robertdouglass commented

Ok.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

MarcusOaten’s picture

MarcusOaten commented
Title: Add an "unclick" link to search keys » Add an "unclick" link to search facet block
Version: 6.x-2.x-dev » 6.x-1.5
Status: Closed (fixed) » Active

Is there any way to add the unclick link to the facet block all the time? Possible saying ( All ) instead of (-).
Just like drupal.org

janusman’s picture

janusman commented
Assigned: janusman » Unassigned

Not assigned to me anymore. =)

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Active » Fixed

Marcusoaten, could you please open a new issue with a clear description + maybe an image/screenshot?
Also feature request will probably first go into the 7.x branch and are maybe backported to D6 in time.
This is a really old issue that was fixed so we'll leave it that way :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.