Download & Extend
Apache Solr Search Integration » Issues

Add an "unclick" link to search facet block

Posted by David Lesieur on May 26, 2009 at 8:20pm
Project:Apache Solr Search Integration
Version:6.x-1.5
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

A user can remove a filter by using the "unclick" link provided in the Current search block. Adding a similar link for the search keys would be convenient and make the UI more consistent.
Of course, this only makes sense with the new capability provided by #358166: Search for just facet(s).

Login or register to post comments

Comments

#1

Posted by janusman on July 6, 2009 at 10:54pm

I'm thinking this is rather trivial?

* Comment above a sad excuse for bumping this =) *

#2

Posted by robertDouglass on July 7, 2009 at 8:59am

This is a nice little feature request that I'd still group in the 6-1--0 branch. Anyone want to take a first swing at rolling a patch?

#3

Posted by janusman on July 7, 2009 at 5:46pm
Assigned to:Anonymous» janusman

Taking this...

#4

Posted by janusman on July 7, 2009 at 9:01pm
Status:active» needs review

Here be a patch.

Took some code from @aufumy's patch in http://drupal.org/node/270412#comment-1747426 to add the public function remove_keys() to Solr_base_query.php

AttachmentSizeStatusTest resultOperations
473554_4.patch1.85 KBIgnored: Check issue status.NoneNone

#5

Posted by robertDouglass on August 13, 2009 at 1:39pm
Version:6.x-1.x-dev» 6.x-2.x-dev

Let's resolve #545094: Method to set Keys on Query first and then get this in.

#6

Posted by pwolanin on August 13, 2009 at 1:52pm

Per discussion w/ Janusman. I think we'll need to change the interface, so we should not put this on the 1.x branch where it would break existing integrations.

I think a set_keys() method is more generally useful, and it's not clear then that we need a remove_keys() method.

#7

Posted by robertDouglass on August 13, 2009 at 3:01pm
Status:needs review» needs work

There are now $query->get_keys() and $query->set_keys().

#8

Posted by janusman on August 13, 2009 at 7:12pm
Status:needs work» needs review

New patch for latest DRUPAL-6--2.

AttachmentSizeStatusTest resultOperations
473554-8.patch1.11 KBIgnored: Check issue status.NoneNone

#9

Posted by robertDouglass on August 13, 2009 at 10:07pm
Status:needs review» fixed

Thank you. Committed to 6.2.

#10

Posted by robertDouglass on August 13, 2009 at 10:07pm
Version:6.x-2.x-dev» 6.x-1.x-dev
Status:fixed» patch (to be ported)

Peter may want to port.

#11

Posted by pwolanin on August 14, 2009 at 1:07pm
Version:6.x-1.x-dev» 6.x-2.x-dev
Status:patch (to be ported)» fixed

If I understand, this requres the interface changes, so we were not going to backport.

#12

Posted by robertDouglass on August 14, 2009 at 2:44pm

Ok.

#13

Posted by System Message on August 28, 2009 at 2:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#14

Posted by MarcusOaten on October 13, 2011 at 3:39pm
Title:Add an "unclick" link to search keys» Add an "unclick" link to search facet block
Version:6.x-2.x-dev» 6.x-1.5
Status:closed (fixed)» active

Is there any way to add the unclick link to the facet block all the time? Possible saying ( All ) instead of (-).
Just like drupal.org

#15

Posted by janusman on October 13, 2011 at 8:57pm
Assigned to:janusman» Anonymous

Not assigned to me anymore. =)

#16

Posted by Nick_vh on October 14, 2011 at 5:48pm
Status:active» fixed

Marcusoaten, could you please open a new issue with a clear description + maybe an image/screenshot?
Also feature request will probably first go into the 7.x branch and are maybe backported to D6 in time.
This is a really old issue that was fixed so we'll leave it that way :)

#17

Posted by System Message on October 28, 2011 at 5:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here