views-view--embed.tpl.php is it working? from your blog post it seems not.

There is a similar issue with Views attach
#380248: views_attach displays do not have own template files; hilarity ensues
but it is not fixed either..

CommentFileSizeAuthor
#10 theme-path.patch853 bytesmerlinofchaos
#4 473784.patch4.31 KBgrndlvl

Comments

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

Views: #473786: Automatic theme template suggestion for new display types

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

-

grndlvl’s picture

grndlvl commented
Assigned: Unassigned » grndlvl

Thanks for the heads up. I will try to get to this this weekend.

Thanks,

Jonathan

grndlvl’s picture

grndlvl commented
Status: Needs review » Active
StatusFileSize
new 473784.patch4.31 KB

Here is the patch to implement the change for adding ability to theme embed views display.

I will commit once it has been tested.

Please let me know if this works out for you.

Thanks,

Jonathan

grndlvl’s picture

grndlvl commented
Status: Active » Needs review
pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Active » Needs review

is this the only 1 template? and why embed_views_display_view is the template name? I really need all the additional display type templates provided by views.

like: (note: embed_1 is the display name in the examples, view_name is the view name)

Display output:
views-view--embed.tpl.php
views-view--view-name--embed.tpl.php
views-view--view-name--embed-1.tpl.php

Style output: (style: unformatted)
views-view-unformatted--view-name--embed.tpl.php
views-view-unformatted--embed-1.tpl.php
views-view-unformatted--view-name--embed-1.tpl.php

Row style output:
views-view-fields--embed.tpl.php
views-view-fields--view-name--embed.tpl.php
views-view-fields--embed-1.tpl.php
views-view-fields--view-name--embed-1.tpl.php

Field output: (field-name is the field name)
views-view-field--embed.tpl.php
views-view-field--embed--field-name.tpl.php
views-view-field--view-name--embed.tpl.php
views-view-field--view-name--embed--field-name.tpl.php,
views-view-field--embed-1.tpl.php
views-view-field--embed-1--field-name.tpl.php
views-view-field--view-name--embed-1.tpl.php
views-view-field--view-name--embed-1--field-name.tpl.php

without these I can't switch to embed display type..

grndlvl’s picture

grndlvl commented

Out of curiosity does all of the templates work w/ attach views... ? Maybe I did something wrong.... Not sure, this is turning out to be more in depth than I had originally thought.... will spend more time on it this weekend.

Thanks for you input Pasqualle.

Jonathan

grndlvl’s picture

grndlvl commented
Status: Needs review » Needs work
merlinofchaos’s picture

merlinofchaos commented

I just installed this to test. There's one minor problem. 'theme path' needs to be set to the Views theme directory so that the views-view.tpl.php file can be found.

Other than that, I tried a couple of different variations from the list provided in theme: information on the embed display and they work perfectly. Any problems you are experiencing are likely not the fault of the display here.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs work » Needs review
StatusFileSize
new theme-path.patch853 bytes

This patch fixes the wrong theme path.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Reviewed & tested by the community

converted all my views with block display to embed display
renamed my "embed" style templates
cleared the cache

everything works correctly

Thank you Earl, perfect solution..

grndlvl’s picture

grndlvl commented
Status: Reviewed & tested by the community » Fixed

Committed. Available in 6.x-1.1.

Thanks,

Jonathan

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.