Leave it to the unstable release when I announce vertical tabs to find this bug. Sigh. :(

Hosed tabs

CommentFileSizeAuthor
#11 vertical-tabs.css_.patch576 bytestic2000
#4 vertical-tabs.css_.patch549 bytestic2000

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

The commit that broke this happened sometime between 5/21 and 5/22:

cvs update: Updating .
P CHANGELOG.txt
P install.php
P update.php
P includes/common.inc
P includes/form.inc
P includes/tablesort.inc
P includes/theme.inc
P includes/theme.maintenance.inc
P includes/database/select.inc
P modules/aggregator/aggregator.module
P modules/block/block.admin.inc
P modules/block/block.install
P modules/block/block.js
U modules/block/block.module
P modules/blog/blog.pages.inc
P modules/comment/comment.admin.inc
P modules/dblog/dblog.admin.inc
P modules/filter/filter.module
P modules/menu/menu.module
P modules/node/node.module
P modules/path/path.admin.inc
P modules/poll/poll.pages.inc
P modules/profile/profile.module
P modules/search/search.module
P modules/simpletest/simpletest.module
P modules/simpletest/tests/common.test
U modules/simpletest/tests/database_test.module
P modules/simpletest/tests/database_test.test
P modules/statistics/statistics.admin.inc
P modules/statistics/statistics.pages.inc
P modules/system/system.admin.inc
P modules/system/system.api.php
P modules/system/system.install
P modules/system/system.module
P modules/taxonomy/taxonomy.pages.inc
P modules/tracker/tracker.pages.inc
P modules/trigger/trigger.module
P modules/user/user.admin.inc
P modules/user/user.module
P modules/user/user.pages.inc
P modules/user/user.test
P profiles/default/default.profile
P profiles/expert/expert.profile
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Got it in one. ;)

#428744: Make the main page content a real block

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Reproduced the same problem in Safari and Firefox. Thought it is my machine. Looks like it is not only me :(

tic2000’s picture

tic2000 commented
Status: Needs review » Active
StatusFileSize
new vertical-tabs.css_.patch549 bytes

Since the issue pointed by @webchick made the main content a block, the main content is wrapped now in a div with the class .block. That made that the css for .vertical-tabs-list was overwritten by

ul, .block ul, ol {
margin:0.5em 0 1em;
padding:0 0 0 1.5em;
}

in style.css.
I don't know if this is the drupal way to fix the problem, but here is a patch that just point the style more precisely so it can't be overwritten by .block ul

I think this is a drupal.css problem, not javascript.
Tested in FF3, IE7 and Safari.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review

Using a more specific selector should be fine. (Did not review the actual patch.)

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review

works 1+

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Component: javascript » drupal.css
tic2000’s picture

tic2000 commented

IMHO all the css inside there should use more specific CSS selectors. After all I don't think those classes are meant as general classes (like .error, .clearfix, etc.)
This way it would prevent other themes, modules to accidentally break the layout again.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

This patch works fine in FF3.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

The patch works but it needs to be re-rolled without windows line breaks.

I think we should add a followup issue to look at making all these selectors more specific, but makes sense to just fix the actual bug here.

tic2000’s picture

tic2000 commented
StatusFileSize
new vertical-tabs.css_.patch576 bytes

I hope the line breaks are ok now

tic2000’s picture

tic2000 commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Applies fine now, fixes the bug. RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Wow, awesome! Thanks SO much for the quick turnaround on this, tic2000! :D

Committed to HEAD. Yay! :) Thanks, folks!

tic2000’s picture

tic2000 commented

I opened a follow-up issue here #474242: Use more specific selectors in vertical-tabs.css so we change the css for all the .vertical-tabs-list css rules

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.