Closed (fixed)
Project:
Web File Manager
Version:
6.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 May 2009 at 06:34 UTC
Updated:
7 Nov 2010 at 16:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gintass commented@6174604 I wonder what browser/OS did you use when this happened?
The same happened to me today and other site administrator complained about webfm folders "disappearing" mysteriously few times. I always found them moved into different folders. I think every time this happened Safari on Mac was used. Also I have WebFM current latest version installed 6.x 2.11
Comment #2
a.bond commentedI've had this frequently happen in Chrome and IE, but not Firefox yet. I've noticed that in chrome and IE there some kind of a bug about mouse position where after you click on a folder, the highlight that indicates where the drag and drop will land is massively offset from the mouse position. This means that frequently in those browsers, what is intended as a single click will be interpreted as a drag and drop into another folder.
Comment #3
Haus33 commentedI have massive complains from users about files "disappearing" after a single click. The files are found found in random folders afterwards. It seems that this only happens with IE6 on XP. I cannot reproduce this problem with my environment FF/Safari on OS X. Webfm version is 6.x-2.11.
Remark: In the Webfm settings I have changed the "IE Drag-and-Drop Normalization" to 0 to enable D&D on IE. With the default values the dragged symbol is glued to the left window border.
Comment #4
Anonymous (not verified) commented.
Comment #5
gintass commentedI wonder if anyone knows whether this happens only with certain Drupal themes.
Comment #6
Anonymous (not verified) commentedI'm using Garland
Comment #7
nhck commentedDear everyone,
there is no way I was able to reproduce this as of yet. Please post VERY detailed steps on how to reproduce this.
Maybe you can try posting detailed steps on reproduction on a vanilla drupal were only webfm is enabled. Also make sure its not an AddOn or activeX component thats interfering.
If this really is a bug we need to fix it.
Thanks and happy easter :-)
Comment #8
cgmonroe commentedI wonder if this is related to the IE offset settings? My untested theory is that if the mouse is moved slightly in the act of clicking on a file, this might be triggering the drag and drop action before the onClick download actions. If the offset is making the drag object appear like it's over a different directory, then releasing the mouse button might be causing the file to be moved.
Comment #9
Anonymous (not verified) commented@cgmonroe that may be a explanation to the problem. for me it only happens in Safari, in Firefox I don't have any problem.
Plus the error only occurs in the users that has Webfm administrator permission because they are the only one who can move folders around.
Comment #10
paul.dambra commentedsubscribing... Noticed in Chrome using a custom theme...has anyone tried with a vanilla install?
Comment #11
paul.dambra commentedHere's an image showing the issue... centre arrow is the mouse level, top arrow the highlighted folder and bottom arrow is the selection "ghost"
Comment #12
cgmonroe commentedDoes this happen if you are using a stock theme like Garland? I wonder if it's related to malformed HTML (e.g missing end tags, etc) or if it might be due to CSS positioning issues (e.g. containing theme related DIV has relative or absolute positioning.. I know that IE and FF have some issues around locating "floating" divs if you don't have the containing divs set up correctly with position type and it's box well defined (e.g. width and/or height defined).
Another thought is that you seem to have a long list of directories, etc. Does the list of directories extend beyond the browser window? E.g., you need to scroll to see all of them? I seem to remember that placement might be related to the view port and not the full document. This could be a bug that shows up when there are a lot of directories... but my memory might have a few parity errors here...
Comment #13
paul.dambra commented@cgmonroe we are clearly both great minds (that is we think alike)... I just came to report that I can consistently reproduce this in Chrome without refreshing if I select folders further down in the structure...
So
1) expand all folders
2) ensure scrolled to top of page
3) select folder near top and observe correct behvaiour
4) scroll down
5) select a folder and observe incorrect behaviour
edit: just tested Firefox on OSX and it works fine but Safari also displays the glitch so I guess it is webkit based...
P
Comment #14
pinky.evakoss commentedI am having the same problem with the latest stable release of the module for D6. I have set the height for the right side directory pane as there are lots of directories in the list. When I scroll the directory listing this issue appears (single click on a directory sends a move request and folder moves to some directory). If I remove height from the div, problem disappears.
But I must have to add height for the directory listing. Can anyone help me out.
Comment #15
nokes commentedWe also are having the same issue in Firefox (not sure about IE or Safari). I can't say that I can replicate the issue from a stock Drupal and WebFM, but I can clarify the behaviour according to what I'm seeing...
1. Open WebFM page
2. Use '+' boxes to open a variety of folders
3. Click a folder
What happens:
a. The left-hand pane reduces completely down to just the root folder showing
b. The right-hand pane shows the contents of the folder *after* the clicked folder (alphabetically)
c. The clicked folder is within the folder shown on the right-hand-side
This is with Firefox both on Linux and Windows, using D6 and either 2.11 or 2.12 of WebFM
More details later if I can figure them out...
Comment #16
paul.dambra commented@nokes that sounds like either a different issue or a useful clue to figure out what is happening on the click event...
I've successfully tested with Firefox - that is I can expand my folder tree, scroll down and drag and drop without issue.
If you click on a folder (I'm guessing in the left-hand pane) and don't release the mouse button what displays on screen?
P
Comment #17
nokes commentedGood call. Yeah, click-and-hold reveals what's happening. When I click-and-hold, the faded-out version of the item is in the proper place, but the folder below it is highlighted for dropping. I'm guessing that single-click seems to put drag 'n drop into action, but for some reason the drop target is offset low.
If I drag the item over the folder above, the highlight for dropping disappears and allows me to let go without any effect. In short, if I want to drop the item into another folder, I have to hover over the one immediately above where I want to drop it.
Comment #18
cgmonroe commentedFind the underlying cause to this is hard... but I think that it would not be too hard to add an alert box to the move action. E.g., a standard JS confirm dialog that says: Confirm move from x to y? Yes/No.
This is not a solution to the problem, but might help keep accidental / unexpected file moves from happening. Does this sound like something that should be added?
Comment #19
charliebrown314 commentedI've had the same problem. Here's exactly what happens.
--Drupal 6 latest stable, Firefox 3.6.3.
--Left and right sides of WebFM forced to same static height.
--Long list of folders appears in left side directory tree. List is long enough that it runs off the bottom of the page. Scrollbar at right of directory tree lets me scroll up and down through the folders listed.
--Imagine you are looking at this on initial load, and there are folders named Apple, Banana, Carrot, etc., all the way through the alphabet. Because I've constrained the height of the display, the last folder I can see without scrolling is Orange. I can click on Orange, or any folder ABOVE it, (Nectarine, Mango, Lime, ... , Apple), and WebFM behaves as expected: the clicked folder's contents appear on the right side of the screen.
So far so good. Now:
--Scroll down even a little bit, and click the very first folder that DIDN'T appear on the screen at initial load (folder called "Pear" in my case). Application behaves as though you had just done a drag-and-drop: it asks for confirmation of file move. Interestingly, it asks you whether you want to move the folder you just clicked to a folder up near the top of the tree. (e.g., click Pear, and it asks if you want to move Pear into Banana).
--Same problem happens with ANY folder that was NOT visible in the screen at initial load.
--Note: whether a folder exhibits this behavior seems to be fixed at initial load and not affected by later actions. In other words, load page, click Carrot, no problem. Load page, scroll to Pear, problem appears. Load page, scroll to Pear, see problem, scroll back up to Carrot, no problem. So it's not that something is changing at some point and producing the problem for all of the items on the page.
Thanks in advance for any help!
Comment #20
aarnold commentedThis has also happened to me. It happened while in chrome, have not tried other browsers yet. Has there been a solution figured out yet?
Comment #21
nhck commented-Left and right sides of WebFM forced to same static height.
How did you achieve this?
Comment #22
smurray23 commentedHi!
We've been having this issue for our website at www.xtuple.org lately, so I was tasked to take a look and see what I could find. After looking at webfm.js's mousePosition function, I tweaked it so that it should work in anything (except IE so far). Not sure how to post a patch, but here's what I did:
This should address the odd moving around issues, as it did for us at least. Maybe this will help find a real solution to the problem?
Comment #23
nhck commentedsumurray23 thank you so much for helping to make webfm better! I really appreciate your work.
Creating a patch for others to test is outlined here: http://drupal.org/patch/create
Comment #24
smurray23 commentedOkay after following the instructions on the link, I'm attaching the patch file created here. Hopefully it helps!
Comment #25
webservant316 commentedDoes the patch at #24 work for IE also? I was planning to use WebFM today to create a bunch of new nodes linking to files already on my server and I ran into this bug. I am using IE8, Drupal 6.16 and WebFM 6.x-2.12.
The problem is so severe that WebFM is unusable in the this condition. Twice in a short period it moved a folder arbitrarily to other sub-folders as explained above. The module appeared to maintain the links to the files within the nodes, however, my folders were moved around and I could not move them back via WebFM. And when I moved them back via FTP all my node links were broken.
Is there a setting to disable WebFMs ability to move or delete files and folders? I plan to use FTP to upload all my file content anyway and just want to use WebFM to attach the files to my nodes. I would prefer to disable WebFMs ability to mess with files altogether even aside from this bug. I prefer to control all that via FTP and simplify the purpose of WebFM to simply attach the files to the node. Maybe there is not a way to disable those features via the WebFM admin interface, but anyone know a hack to the code that would disable those features?
More added...
Perhaps I can just avoid using the folder+ in the left hand pane and navigate using the right hand pane and this bug will be avoided. However, please note that in IE8 when I click on a folder in the right hand pane that the whole browser windows rescrolls to the top. I then have to scroll down to the WebFM area and the new folder is opened, but of course that is no fun that my window scrolled up automatically. This does not happen in FF so perhaps I will just use FF for this particular job. I looked for another post on this additional issue but didn't see one.
Comment #26
webservant316 commentedRemoved Firefox from title since observed in IE as well.
Comment #27
cgmonroe commentedOn thing you can try to fix the drag and drop in IE is to play with the "offset" setting in the WebFM admin screen. I think the defaults are for IE6 and later IE's do a better job. I tend to set this to 0's and then see where the icon displays.
As to disabling directory moving, a quick hack would be to you could probably modify the webfm_ajax function so that the case that handles moving directories denies everyone access.
Comment #28
webservant316 commentedNot sure I want to mess with WebFM code without understanding more. So I will probably watch this discussion for the patch or better yet a new release. In the mean time I've learned that webfm works better in FF so I am doing all my admin over there now. Also I just avoid the left hand folder browsing pane altogether. Really since the folder path links are at the top of the right hand pane the left hand pane is not needed to navigate whereever one wants to go. I know you may want to solve this problem, but you could also simplfy the whole interface and get rid of the left hand pane. (though maybe it is needed to make moving folders and files more convenient).
Another aside, I read above that if webadmin priviledges are turned off that the user cannot move folders anyway. That would be a solution for me since I do not plan to use webfm to move folders. However, I ran into a problem trying to turn off those perms. I typically do admin with an account 'webmaster' assigned to an admin role rather than use the Drupal user 1 for admin. So I planned to turn off webfm admin priviledges and upload priviledges for 'webmaster' with the 'admin' role, but curiously those permission cannot be turned off for the 'admin' role. I use the 'adminrole' module which assigns all new perms to the selected 'admin' role. However, I should then be able to turn off the perms for the admin role if I chose, at least I can for other modules. However, I cannot turn off the perms for 'administer webfm' and 'webfm upload.' The perms form submits properly, and the perms are initially turned off, but something eventually turns the perms back on.
HMMM, more information. After further testing I could change the perms of my admin role. I may have been confused with language because of have created a role called 'admin', but the 'admin' mentioned on the webfm administration page must be talking about the 'admin' user or drupak user #1. I am still wrestling with perms, but ignore this paragraph till I get more info. Current problem is that the 'upload' option still displays even though the perms are turned off.
Comment #29
cgmonroe commentedFYI - The Drupal standard is that user id #1 has ALL rights regardless of role settings. E.g. user_access(xxx) always returns true if you are user #1. Webfm follows that standard.
Comment #30
nhck commentedwebmaster_prwa, are you sure you expierience exactly the same offset as illustrated above - or is it different? If so please open a different issue - this goes for your support questions as well. Thank you.
Comment #31
nhck commented#473918 by smurray23 | cgmonroe, paul.dambra: Fixed directory automatically moved to inside another directory.
Tried to get a deeper understanding of this and found that there is a bug in Chromium (http://code.google.com/p/chromium/issues/detail?id=2891) which hasn't been fixed for a long time now thus I am committing this. According to jQuery(http://docs.jquery.com/Tutorials:Mouse_Position#How_do_I_find_the_mouse_... an) and quircksmode.com (http://www.quirksmode.org/dom/w3c_cssom.html#mousepos) this shouldn't fix the Firefox Problem in my opinion. On the other this condition seems very rare - I wasn't able to reproduce it.
So it would be nice if everyone could test. Please always report your browser version and use Garland for testing.
Thanks again to everyone that helps with this.
Comment #32
webservant316 commentedI probably didn't communicate clearly. I know that user #1 has all perms.
Instead I use the 'adminrole' module to create a new user group of admins.
I cannot turn off the upload perm for users in that group.
I've created a new issue this this question.
Comment #33
Haus33 commentedComment #34
jm.federico commentedignore this comment
Error on my side, didn't mean to upload the file.
Comment #35
nhck commentedDear all,
thank you for reporting and helping to make webfm better. I have committed a possible fix to CVS. Unfortunately I do not have MSIE < Version 9. It would be nice if some one could take the time and test it properly.
Again thank you very much.
#473918 by smurray23, jm.federico | cgmonroe, nhck, paul.dambra: Fixed directory automatically moved to inside another directory.
Comment #36
nhck commented