nodeapi load getting called twice on node edit?

node_load is cached, so no prob.

nodeapi load is not called twice (at least it should not).

i can't reproduce this. i added some debug code to book_nodeapi('view') and is called once for a node view. mayeb disable all contrib stuff. sounds like a loop is happenning somewhere

I did what moshe outlined above, except I added case 'load': to book module's hook_nodeapi, not view.

I can't reproduce the problem. When I view node/## I just get one print statement.

Now, if I view just node, I get several, but that's because there will be one load call for each node on the page.

So is it possible that the page you're looking at is comprised of 2 or more nodes somehow?

Sorry, noticed you said node edit and path.module. But same thing... only one print statement.

Right.

case 'load' on hook_nodeapi

when going to node/##/edit

Still can't reproduce.

Any further hints?

Hm, hm.

Hm, hm, hm.

yes, but the first patch was broken :) it returned the core info only not the cached stuff.

Even better.

Why is the last patch better than the previous one?

i also think that both of them are flawed a bit by setting the cache parameter to node->nid.

try this:
$node = node_load(array('nid' => 48, 'uid' => 1));
print_r($node->body);

$node = node_load(array('nid' => 48, 'uid' => 2));
print_r($node->body);

if this happens on the same page request (and the first returns a valid node) then the second will return the same node, although there is no node which matches the condition.

This does not happen with the current node module

I can't verify wtanaka's issue in the first place. There is no node_load in path.module.

Currently, node_load is only cached if it is called with a numeric argument. As I have shown, this is a good thing, since otherwise problems could occur.

The only place in core where node_load is loaded in a non-cacheble way is in poll.module (once) and a couple of times in node.module (in the revisions code).

Let's put this issue to the rest. If it can't be cached, well, then it can't.

Well, we are already iterating the param array, so why not.

wtanaka: Only non-cachable node_loads will call nodeapi at all. Is it possible you use some modules which still use the depcrecates node_load(array('nid' => n)) syntax? These would indeed call nodeapi.

< chx> more than 99% of the time the node is cached
< chx> and when not, then not
< chx> and yes, then nodeapi load is called twice
< chx> so is hook_load
< chx> i feel fine with that
< chx> mark it won't fix

ps the above comment where from chx, forgot less-than and greater-than are striped

I wrote the following code
function test_block($op = 'list', $delta = 0, $edit = array())
{
if($op == 'view')
{
$node = node_load(array('type' => 'forum', 'uid' => 1));
$block_content = $value->title;
$block['content'] = $block_content;
}
return $block;
}

the user with uid=1 have two posts in forum but my code returns only one post.