On Activity publisher templates I'm adding new Activity Types -> Flag friend -> Triggers -> remove: A user removes another user as a friend.
On public pattern I'm using code: <a href="[requestor-url]">[requestor]</a> remove from friend <a href="[requestee-url]">[requestee]</a>. After user1 remove user2 from friend, in activity log I see 'user1 remove from friend user1'.

Comments

sirkitree’s picture

sirkitree commented

I noticed this too... there seems to be some sort of mixup in the token replacement that I haven't pinpointed just yet.

sirkitree’s picture

sirkitree commented
Title: Error with token when unflag friend (Flag friend module) » activity integration op 'remove' is missing data
Project: Activity » Flag Friend
Version: 6.x-2.x-dev » 6.x-1.x-dev
Assigned: Unassigned » sirkitree

Further testing reveals it only happening to the 'remove' op. Also getting various array function errors. Moving this to flag friend queue and will continue investigating.

sirkitree’s picture

sirkitree commented
Issue tags: +activity2-integration

tagging

sirkitree’s picture

sirkitree commented

array errors are as follows:

  • warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in /Users/jbitner/Sites/comm/html/sites/all/modules/contrib/activity/activity.module on line 531.
  • warning: array_keys() [function.array-keys]: The first argument should be an array in /Users/jbitner/Sites/comm/html/sites/all/modules/contrib/activity/activity.module on line 468.
  • warning: array_diff() [function.array-diff]: Argument #1 is not an array in /Users/jbitner/Sites/comm/html/sites/all/modules/contrib/activity/activity.module on line 468.
  • warning: Invalid argument supplied for foreach() in /Users/jbitner/Sites/comm/html/sites/all/modules/contrib/activity/activity.module on line 482.
sirkitree’s picture

sirkitree commented

ok array merges were related to another problem. tokens are still not being translated corrected upon remove though.

sirkitree’s picture

sirkitree commented
Status: Active » Fixed

Fixed in CVS - http://drupal.org/cvs?commit=220118

The place where we called module_invoke_all('flag_friend', 'remove', ... was being passed the incorrect $account.

This also splits out the js into it's own file.

Status: Fixed » Closed (fixed)
Issue tags: -activity2-integration

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +activity2-integration

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.