I suddenly get warning I did not get before:
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('uc_credit',$message,WATCHDOG_ERROR) in payment/uc_credit/uc_credit.module on line 884.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('uc_cybersource',$error,WATCHDOG_ERROR) in payment/uc_cybersource/uc_cybersource.module on line 372.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('google',check_plain($response_obj->error),NULL,WATCHDOG_ERROR) in payment/uc_google_checkout/uc_google_checkout.module on line 623.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('google',check_plain($error),NULL,WATCHDOG_ERROR) in payment/uc_google_checkout/uc_google_checkout.module on line 629.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('google',$message,NULL,WATCHDOG_ERROR) in payment/uc_google_checkout/uc_google_checkout.module on line 1034.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('uc_paypal',$error,NULL,WATCHDOG_ERROR) in payment/uc_paypal/uc_paypal.module on line 967.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('quote',$messages,NULL,WATCHDOG_WARNING) in shipping/uc_quote/uc_quote.module on line 404.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('quote',''.print_r($quote_data,TRUE).'',NULL,WATCHDOG_WARNING) in shipping/uc_quote/uc_quote.module on line 405.
* Invalid menu 'title' definition found in uc_catalog_menu(). Title and description keys of the menu array should be literal strings. In uc_catalog/uc_catalog.module on line 65.
* The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('JSimpleXML','XML Parsing Error at '.$line.':'.$col.'. Error '.$code.': '.xml_error_string($code),WATCHDOG_ERROR) in uc_store/includes/simplexml.php on line 266.
Somebody can explain what is happening? Why suddenly the messages, one time and then no more? I normal user would see them too?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | ubercart-474000-1.patch | 3.18 KB | cedarm |
Comments
Comment #1
rszrama commentedCedar's checkin' this stuff out beside me right now. : )
Comment #2
cedarm commentedNot sure where these warnings were actually coming from. Looks like coder module stuff.
Anyway, there's some watchdog calls, and a menu title that actually are invalid, so here's a patch to fix up some of it. Some of these warnings are technically invalid, because the third argument to watchdog() is allowed to be NULL if the message is not translatable.
Comment #3
rszrama commentedSimpleXML hunks failed for some reason, but I'm not worried about it since that file should be deprecated anyways (separate issue). Committed. : )
Comment #4
cha0s commentedHEAD is broken...
Comment #5
rszrama commentedYep, saw that this morning. Fixed the quote. :-/