Use taxonomy_load functions in blogapi.module

Subscribing. Not sure if vocabularies should have a different tag or not. Since we already do the node type join for vocabularies it doesn't seem too bad adding it for terms too - certainly a lot nicer than blogapi querying directly.

Also, this code will have to change drastically if and when #412518: Convert taxonomy_node_* related code to use field API + upgrade path gets in. Long term that's going to be the way to remove special casing of nodes in taxonomy.module, but while we've got it, might as well have it centralised.

Took another look at this and I'm happy. Marking RTBC.

A delightful side note is that this appears to kill off the last use of the db_placeholders in core which "is deprecated in Drupal 7 and will be removed as soon as it is expunged from core".

1 function calls db_placeholders. Very nice.

You calculate the array_unique($node->taxonomy) twice.

Would it be better to simply do:

      $term_list = array_unique($node->taxonomy);
      $terms = taxonomy_term_load_multiple($term_list, array('type' => $node->type));

and:

      if (count($term_list) != $found_count) {

Re-rolled. It appears someone removed the drupalLogin($web_user) call, which the patch from #12 also removed.

Hate to do this but:

+    $this->assertFalse($result, t('Post categories fail validation (attempt to post two when one is allowed).'));
+    // Change to required.
+    $this->updateVocabulary($vid, 'simpletest_vocab1', FALSE, TRUE);
+    $result = xmlrpc($local, 'mt.setPostCategories', $nid, $web_user->name, $web_user->pass_raw, array());
+    $this->assertFalse($result, t("Post categories fail validation (none posted when it's required)."));
+    // Change to allowing multiple, not required.

Could use a line break before those inline comments to make the test code less dense.

Rerolled with spacing change request from #16.

lovely.

Committed to CVS HEAD. Thanks!