Posted by eldrupal on May 27, 2009 at 11:32am
Jump to:
| Project: | Language icons |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (works as designed) |
Issue Summary
Hi, this is a superb module! Thank you for developing and sharing it.
I would like to request a new feature: Is it possible to add controls that would permit the removal of the flags' bullet points. I feel that the presence of the flag icons is sufficient and replaces the bullet points. Otherwise, how can I remove the bullet points myself? The module's code does not add them. Is there a way to instruct the theme() function not output them? My website does not look consistent with the present format.
Thank you,
DrupalFan
Comments
#1
Hello:
First of all, thanks for sharing the module. I am also interested in just displaying the flags, no bullets and no text. It would be great to get this feature integrated in the module
Cheers
#2
As a workaround, you can get rid of the bullet points with e.g. the following CSS, which also makes the flags display inline:
div.block-locale ul li {display: inline;
list-style-image: none;
margin: 0px 2px;
}
#3
Hello Andrew,
1. Where should this css code be placed? Does it have to be in the active theme's style.css?
2. If it actually does need to go in the style.css of every theme, how can we make it global so it can work on all themes? I'm asking because I use a lot of themes (via Theme Switcher) and it would be a pain adding it to every theme.
Thank you in advance for your time. Wishes for a happy 2010 to you and everyone ;)
#4
Never mind the first question above. I tested myself and found out (I kinda already knew). Note-to-self: Test before posting... Test again... Scratch head a bit more... Then ask questions ;)
If you know the answer to the second question though, it would be great!
Also, the code above didn't remove the bullets for me. It simply made flag icons display inline. Any thought on that?
#5
klonos, there are some contrib modules that allow you to add some CSS to every theme: e.g. http://drupal.org/project/css_injector (which seems to be abandoned) and http://drupal.org/project/customcssjs. You can probably find others.
As for why the bullets didn't go away, it seems likely that there's some other CSS that's overriding the list-style-image. The web developer extension for Firefox is good for debugging this sort of problem-- try CSS > View CSS and CSS > View style information.
#6
Thank you Andrew,
thank you for the information. I will try and figure my way through this one with the help of these modules. Been having web-dev and firebug installed since... I don't know when. I knew there would come a day I'd need to get my hands dirty ;)
BTW, it seems that the developer of the second is trying to merge the two modules so that features of both can be combined. Take a look here:
- Custom CSS and JavaScript files module's issue queue: #573094: See the CSS Injector module and decide how to relate to it
- CSS Injector module's issue queue: #669106: Merge custom css and js module with css injector
#7
It would be great if the developer for language ICON can add this to the module setting. It is very much needed.
The problem with injecting CSS is when you update your system all these costume work tend to disappear and you are back to start again.
#8
@ koyanumi: This is an option that is theme dependent, and I don't feel that we should do all the cumbersome work of adding an option and actually making the option work properly. It's just as easy making a quick child/sub theme of whatever theme you're using, and adding your custom CSS file to that. Of course, this then yields problems when you're using several different themes (@klonos), but there are other ways to deal with this.
@ klonos: Any news on what is over-writing your CSS?
#9
Hi Freso, I'm afraid no news on it yet :(
I had to postpone this minor issue because of other important issues that came up with the site's development. I will post back as soon as I get on it, but no timeline. Sorry.
#10
Alright, let's close this issue.
#11
Automatically closed -- issue fixed for 2 weeks with no activity.
#12
I must protest this issue being closed. The Language Switcher is going to be a very prominent front-page feature of my site, and it's incredibly distracting for the bullet points to be there. Trying to be resourceful, I searched the internet for a solution and came up with this post...which yielded no solution. After a couple weeks of waiting, thinking I would "just figure it out", I have come up with nothing. This thread should explain the process, in detail, of removing the bullet points -- at the very least. It would be even better if the theme itself was updated to make it an option to take the bullet points off.
It's essential.
#13
Then you did not read the issue thoroughly. I especially recommend you read comment #2 very closely.
That is one excellent idea! So go file an issue (well, feature request, really) with the theme you're using. :)
#14
Thank you!