Node create/edit page looks fine with vertical tabs. Comment settings in this page has help text like 

Users with 'post comments' permission can post comments.

Obviously this help text will make a newbie to search for permission settings, so i think its better to have this text links to admin/user/permissions page. I have attached a patch to do this task, please test it and let me know your suggestions.

CommentFileSizeAuthor
drupal_comment_settings_1.patch1.03 KBsivaji_ganesh_jojodae

Comments

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Active » Needs review
shawn dearmond’s picture

shawn dearmond commented
Component: node system » comment.module
Status: Needs review » Reviewed & tested by the community

I applied this patch to D7 HEAD and it did what it was advertised to do.

yoroy’s picture

yoroy commented
Status: Reviewed & tested by the community » Needs work

Did you click the link? From reading the patch (not applied it) I think there is a "/" missing here:
l(t('permission'), 'admin/user/permissions')) shouldn't that be
l(t('permission'), '/admin/user/permissions')) ?

shawn dearmond’s picture

shawn dearmond commented
Status: Needs work » Reviewed & tested by the community

Yes, I clicked the link; and no, you don't need the leading "/". The l() function uses internal Drupal paths which do not include leading slashes.

yoroy’s picture

yoroy commented

whoops, pardon my code ignorance. All good to go then.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

Please run this code in your Execute PHP block and find the difference.

echo l(t('permission'), 'admin/user/permissions');
echo "\n";
echo l(t('permission'), '/admin/user/permissions') ;

output

<a href="/quiz-dev/admin/user/permissions">permission</a>
<a href="/quiz-dev//admin/user/permissions">permission</a>

yoroy--

yoroy’s picture

yoroy commented

yah nevermind me, I don't code so will refrain from commenting on it :)

Bojhan’s picture

Bojhan commented
Issue tags: +Quick fix

Attaching quick fix for webchick

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

That's not quite right. It should be something like <a href="@url">permission</a> ... array('@url' => url('admin/user/permissions') (check other similar strings in core). We like to keep the link title in the string to provide translators context.

shawn dearmond’s picture

shawn dearmond commented
Status: Needs work » Needs review

Ya know... after thinking about it for a minute from a ux perspective, I'm not sure this issue should be fixed. The user who sees this message may not have access to administer permissions. Indeed, none of the other settings at the bottom of a node form have links to the permissions page, why should this one?

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Assigned: sivaji_ganesh_jojodae » Unassigned
Status: Needs review » Closed (won't fix)
mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

Resetting title after spam.