Edit Term hijacks "Image Gallery" paths

asb - May 27, 2009 - 13:16
Project:Edit term
Version:6.x-1.1
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

Hi,

if "Image Gallery" (from "Image" module) and "Edit Term" are enabled on D6, "Edit Term" hijacks the "Image Gallery" paths (./image/tid/...) and causes an "Access denied" error when accessing a sub-gallery. For some funny reason those galleries can be accesses by non-default paths like ./image/term/1918 or even ./image/boogaloo/1918. A detailed description of the symptoms and some comments from the module's maintainers are available in 473006.

Historical notice: I've been running "Edit Term" and "Image Gallery" on D5 for years; the problem started to occur after upgrading to D6. I can replicate the error, but there might be other factors involved.

Greetings, -asb

#1

dman - May 27, 2009 - 15:23
Status:active» needs review

You are right. I was able to replicate.
Looks like something changed either in the D6.8+ menu handling, or the updates of image_gallery.module.

The boogaloo paths are because image_gallery is ODD in the way it captures the menu requests - it just takes everything under /image/* , then assumes the next argument is 'tid', then looks for the number :-}
That sorta dates back to Drupal 4.6 or earlier.

Anyway, the error was because edit_term tried to capture /image/tid/% away from image_gallery.module, but image_gallery wasn't using /image/tid/% as the path to match in the first case :-}

SO ANYWAY - I've put a patch into CVS that, after some guesswork, seemed to get it working again for image galleries.
give that a go. I'f it's OK for you, I'll call it an update, because without it it sure is broken.
CVS-dev may not roll for a while, here's the dev module.

AttachmentSize
edit_term-DRUPAL-6--1.tar_.gz 5.72 KB

#2

asb - May 27, 2009 - 17:31
Status:needs review» fixed

Hi Dan,

thank you very much for this quick solution; the attached version works for me and solves the issue. If nobody objects, this could become a new release.

Greetings, -asb

#3

dman - May 27, 2009 - 23:56

Thanks for the feedback.
That's going in as a version 6--1-2. Should roll soon.

#4

System Message - June 11, 2009 - 00:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.