Each block calls outbody_of_block(), which prepares and returns HTML.
Changing this to a theme function will allow themers to override the module's default HTML, giving more control over the presentation. Moving the SQL to a template preprocess call allows better separation of markup from logic.
Patch attached is against HEAD.
| Comment | File | Size | Author |
|---|---|---|---|
| content_slider_use_theme_layer.patch | 7.08 KB | manarth |
Comments
Comment #1
Rosamunda commentedHello there!
I´m trying to apply your patch, but it seems that tortoise won´t let me do it.
I´ve checked the patch out, and found that the file content_slider.tpl.php doesn´t exist...
Comment #2
manarth commentedHi Rosamunda,
The file content_slider.tpl.php doesn't exist in the original module; it's a new file (and *should* be created as part of the patch). I guess Tortoise might have issues trying to apply a standard linux-format patch...There are instructions on applying patches for Windows users here: http://drupal.org/node/32627
If you run into probs, here are the contents of the two files:
content_slider.tpl.php
content_slider_row.tpl.php
Comment #3
Rosamunda commentedMANY, MANY THANKS MARCUS!
Comment #4
mixman commentedThanks for the patch.
Why isn't this in the repo?
It's a simple, but also a VERY needed functionality.
Comment #5
manarth commentedmixman: I believe this module is abandoned - the auther contributed a number of modules/themes over a year ago, but hasn't committed to any of them for at least a year.
I'll kick off Drupal's abandoned module procedure: http://drupal.org/node/251466
Comment #6
sudeepg commentedFixed in the latest release.
-- Sudeep