It annoyed me that the Check policy of the Check payment method only appears at checkout when you choose the payment method. This patch includes the Check policy in orders and invoice.

Comments

rszrama’s picture

Any chance you can reattach this patch w/o zipping it up? Plaintext attachments can be quickly reviewed in browser as we blaze through the issues in bulk. : )

ñull’s picture

rszrama’s picture

Issue tags: +ubercamp sprint
itsmahitha’s picture

Assigned: Unassigned » itsmahitha
Status: Needs review » Reviewed & tested by the community

Tested and feature is working.

tr’s picture

Assigned: itsmahitha » Unassigned

What version of Ubercart did you apply the patch to ? The issue is marked 6.x-2.0-rc3.

tr’s picture

Status: Reviewed & tested by the community » Needs review
tr’s picture

Version: 6.x-2.0-rc3 » 7.x-3.x-dev
Status: Needs review » Needs work

Templates have changed since this patch was made. Moving to 7.x-3.x. We can fix it up there, then bring it back here ...

timtunbridge’s picture

+1 for this in 7.x subscribing

Island Usurper’s picture

Status: Needs work » Needs review
StatusFileSize
new4.54 KB
bwynants’s picture

please also see #1186848: payment policy on invoice is it about the same? seems like my fix is less complex...

tr’s picture

@bwynants: Please test the patch in #9 to see if it solves the problem. If you have specific suggestions for how it should be changed please explain them and post a new patch in this issue.

bwynants’s picture

Issue tags: -ubercamp sprint
StatusFileSize
new1.77 KB

Isn't this simple patch achieving the same goal? it adds the policy for 'check' and 'cod'.

mariagwyn’s picture

Patch at #9 and #12 both fail to apply to 7.x-beta3 (12 just has bad format anyway). Does this have to be applied to dev? Little concerned about running a dev on a live site.

thanks,
Maria

mariagwyn’s picture

Okay, I tried #9 on a local dev version (downloaded today):
error: patch failed: payment/uc_payment_pack/uc_payment_pack.module: 137

note that on the beta3 version, patch failed...:446.

I don't know enough about patching to know what that means. I just know that I can apply patches. Happy to test again...

Maria

longwave’s picture

#12 applies fine for me; it is a git style patch, and should be applied with "patch -p1".

mariagwyn’s picture

The instructions for applying a git patch are: git apply -v [patchname.patch]. Did this. Failed.

The old patch -p1 instructions aren't even online. I tried this: patch -p1 < file.patch, and "6 out of 7 hunks failed, saving rejects ..."

Why should a git style patch be applied with patch -p1?

longwave’s picture

#12 patches fine for me against latest 7.x-3.x-dev.

longwave@home:~/projects/ubercart3/drupal/sites/all/modules/ubercart$ git rebase origin/7.x-3.x
Current branch 7.x-3.x is up to date.
longwave@home:~/projects/ubercart3/drupal/sites/all/modules/ubercart$ curl -s http://drupal.org/files/issues/475576-paymentpolicy.patch | patch -p1
patching file payment/uc_payment/uc_payment.tokens.inc
patching file uc_order/templates/uc-order--customer.tpl.php

"patch -p1" ignores the a/ and b/ filename prefixes used in git-style patches.

mariagwyn’s picture

can you give me the exact syntax you are using to apply this patch?

Status: Needs review » Needs work

The last submitted patch, 475576-paymentpolicy.patch, failed testing.

mariagwyn’s picture

I finally applied this patch by hand, and it works. However, it only shows the policy. i would also like the mailing address for checks to show on both the invoice, not just the policy itself. Is this possible?

mariagwyn’s picture

On most recent dev, still had to apply the patch by hand, still only shows policy but not check address. Can this be addressed?