Needs work
Project:
Ubercart
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 May 2009 at 16:39 UTC
Updated:
2 Jan 2012 at 22:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
rszrama commentedAny chance you can reattach this patch w/o zipping it up? Plaintext attachments can be quickly reviewed in browser as we blaze through the issues in bulk. : )
Comment #2
ñull commentedComment #3
rszrama commentedComment #4
itsmahitha commentedTested and feature is working.
Comment #5
tr commentedWhat version of Ubercart did you apply the patch to ? The issue is marked 6.x-2.0-rc3.
Comment #6
tr commentedComment #7
tr commentedTemplates have changed since this patch was made. Moving to 7.x-3.x. We can fix it up there, then bring it back here ...
Comment #8
timtunbridge commented+1 for this in 7.x subscribing
Comment #9
Island Usurper commentedComment #10
bwynants commentedplease also see #1186848: payment policy on invoice is it about the same? seems like my fix is less complex...
Comment #11
tr commented@bwynants: Please test the patch in #9 to see if it solves the problem. If you have specific suggestions for how it should be changed please explain them and post a new patch in this issue.
Comment #12
bwynants commentedIsn't this simple patch achieving the same goal? it adds the policy for 'check' and 'cod'.
Comment #13
mariagwyn commentedPatch at #9 and #12 both fail to apply to 7.x-beta3 (12 just has bad format anyway). Does this have to be applied to dev? Little concerned about running a dev on a live site.
thanks,
Maria
Comment #14
mariagwyn commentedOkay, I tried #9 on a local dev version (downloaded today):
error: patch failed: payment/uc_payment_pack/uc_payment_pack.module: 137
note that on the beta3 version, patch failed...:446.
I don't know enough about patching to know what that means. I just know that I can apply patches. Happy to test again...
Maria
Comment #15
longwave#12 applies fine for me; it is a git style patch, and should be applied with "patch -p1".
Comment #16
mariagwyn commentedThe instructions for applying a git patch are: git apply -v [patchname.patch]. Did this. Failed.
The old patch -p1 instructions aren't even online. I tried this: patch -p1 < file.patch, and "6 out of 7 hunks failed, saving rejects ..."
Why should a git style patch be applied with patch -p1?
Comment #17
longwave#12 patches fine for me against latest 7.x-3.x-dev.
"patch -p1" ignores the a/ and b/ filename prefixes used in git-style patches.
Comment #18
mariagwyn commentedcan you give me the exact syntax you are using to apply this patch?
Comment #20
mariagwyn commentedI finally applied this patch by hand, and it works. However, it only shows the policy. i would also like the mailing address for checks to show on both the invoice, not just the policy itself. Is this possible?
Comment #21
mariagwyn commentedOn most recent dev, still had to apply the patch by hand, still only shows policy but not check address. Can this be addressed?