Seriously. This thing just sucks.

a) It contains administration instructions, yet is visible to anonymous users. #409788: Anonymous users should never see "welcome to Drupal" screen
b) It's hard-coded and not editable. (I know there's an issue for this; can't find it)
c) The instructions are not helpful; they tell you to configure 20,000 things before actually doing anything on your site. #295369: Welcome message re-ordering
d) It's the ONLY help we offer people when they install Drupal and it DISAPPEARS COMPLETELY when you add your first piece of content. (I know there's an issue for this too! Grr!)

And a bunch more related issues:
#270918: UB Usability : fix inconsistent labels and terms on the default welcome page
#78802: Drupal welcome message displays if the front page only has blocks and views
#79582: Add example content to the experimental out-of-the-box demo install profile
#423724: Help landing page: what should be on it, how would it look.
#126221: Make 'node' empty text themable.

But seriously now. Let's set aside incremental changes for a moment and brainstorm how to fix this stupid thing once and for all.

Comments

emmajane’s picture

In my dream world the front page text:
- is a block that I can move around and which does not disappear as soon as I add text.
- not visible to anonymous users (and is configurable like a normal block)
- editable so that I can update the instructions for "new site administrators" after deploying Drupal.
- contains images that relate to the admin screens (assuming there are graphics in the new admin interface for things like adding content).

The dream was a little hazy on what the words actually said, but that might be because it was more graphical and less wall-of-text-ish.

himerus’s picture

+1 agree heavily.

I always wished that when I install a site for testing... that this welcome screen was just GONE... GONE as in Amber Alert gone...

I always have to go in and import some content, create some lorem ipsum nodes just so I can really start playing with my theme. Why can't we just create some default nodes that have similar site usage instructions in it, but at the same times sort of provides a nice variety of XHTML elements (UL, OL, Table, etc) for the theme developers to get a good sense of how the content will render on a variety of elements without manually having to create a CSS tester page. (I have a standard template I use to throw in every type of element I will ever use on the site)

emmajane’s picture

Hm. I think for theming purposes it would be better to "just" use the devel module [1] which has an option to insert dummy content. Although one of the points on the welcome *block* could be instructions on how to do exactly that.

[1] http://drupal.org/project/devel

joshmiller’s picture

Why not redirect to the dashboard and set a "message" that links to documentation within the site on what to do next?

emmajane’s picture

I don't like the idea of a re-direct, BUT what if the $content block by default had a little message (with a link) that said, "No content created. Create some content now." I would be fine with that kind of message disappearing once content is added. Or maybe the screen: node/add could appear in $content if no content had been created at all for the site? This is just crazy talk now, I know!

webchick’s picture

Just a note that we should bear in mind i18n when we're discussing solutions. Probably the only good thing about the welcome message is it's wrapped in t(), which means it can be translated.

joshmiller’s picture

Actually, I think this issue should be resolved by Install Profiles.

#79582: Add example content to the experimental out-of-the-box demo install profile

rfsbsb’s picture

I hate dummy text but I agree simple instruction on creating content right after install is a good idea. The other instruction that already exists may be the first screen on help menu or something like that. This is what happen for a logged in/admin user. For anonymous user they could only see a "There's no content created yet, come back soon" or something else more complex :-)

webchick’s picture

#79582 changes it to a variable rather than hard-coding it. I'm not sure it makes it editable and localizable, though.

But I kind of want this issue to take a step back from existing issues and think about this from a holistic approach. If we were to start all over with providing initial set up instructions to people, how would we do it?

shawn dearmond’s picture

I wrapped the default welcome message in a theme function, with an $account object as the argument. This way, themes can override the welcome message... including the default theme (garland, or whatever your favorite install profile uses).

The contents of the default welcome message is still up for debate, but now that the $user is passed to it, we can use some code to determine what should be shown to the user. For instance, (just brainstorming here), if the user actually has access to install modules, then show the line about enabling modules. If the user only has access to create an article node, then provide a link to create a new article.

http://drupal.org/node/409788#comment-1639518

For the record, I like @emmajane's idea about making it a block.

emmajane’s picture

I think it's important to consider *who* we're providing these instructions to. For example, the person who's "setting up" a Web site is probably also user/1 and has access to the 'admin' interface. Most of the instructions are currently admin-ish things. So wouldn't it make sense to have them available from /admin? This would put the instructions "near" the things they are related to.

@rfsbsb: I think this is along the same lines as what you were suggesting?

The current steps are as follows:
1. Configure your website
2. Enable additional functionality
3. Customize your website design
4. Start posting content

I think the front page should include a variation only the fourth item only:
You have no content, start creating content!

My understanding is that the new admin dashboard will appear regardless of where you are in the site? What if the text for 1, 2, 3 were replaced with a single "HELP" or "GET STARTED" button in the dashboard?

Noyz’s picture

+1 on #7. Seems that people need to be oriented, but the current orientation is not working. IMHO, it's the result of too much text that's generic to all users. As stated in #11, the *who* needs to be better defined, and install profiles might help with that.

shawn dearmond’s picture

Making the default message a theme function could help with this. Not only can a theme (assumably part of the install profile) determine exactly what the content of the welcome message says, but the theme function also gets passed an $account (usually the $user) object, so more user-specific messages can be shown. I scratched the surface of this in my patch here which also creates an unordered list of content types the current user has permission to create, with links to the node/add/$type form. I don't think it's the be-all-end-all of the content of this message, but it opens up possibilities.

@emmajane has the most important point here. If there is no content yet, and someone needs to know what to do next. We should make it as easy and obvious as possible to create content.

boris mann’s picture

+1 to joshmiller -- this should be install profile specific

#79582: Add example content to the experimental out-of-the-box demo install profile

Remember, even "out of the box" Drupal is just the "default" install profile. So let's make this thread how to *implement* this feature.

yoroy’s picture

Yes, this is a extremely critical screen. It's where installation ends and your Drupal site starts. And yes, should probably be install profile specific. Though for default, I agree with #11 in that we should get people to their first "Hello world" post as quickly and smoothly as possible.

Do we postpone this issue on #79582: Add example content to the experimental out-of-the-box demo install profile or continue the brainstorm? Not sure what "how to implement" means, seems that's what the discussion in 79582 is about.

joshmiller’s picture

Brain-dump:

  1. Help them create content #11 +++++1 EmmaJane hit the nail on the head.
  2. Clean it up - The welcome message needs a better format. It just looks ugly and is hard to read so many paragraphs. Clean it up visually and work on the content so that it is more precise
  3. Installation Profiles - should be able to completely customize where you go and what you see.
  4. Why the homepage? - Right now you're taken to "the homepage" -- Why not take them to a "Getting Started" section and turn the site "offline" by default?
  5. The homepage only makes sense to blogs Why not make it a node that links to "Getting Started" and gives them Drupal's best usability feature: the edit button. We need to stop pretending that core has views, unless it will have views, and then that's a different question altogether.
  6. When is the site "new" ? Lots of issues have been sidelined because it hard or impossible to tell if a site is a new installation. Let's make it a simple variable and pray this doesn't turn into a "delete the user" issue
  7. Do you know what you're doing? y/n Angie wants us to think big, right? Check out this guy's awesome idea for Drupal Installation / Welcome -- some of it is d7ux, but the most interesting part, asking for an assisted setup, has not been addressed yet by lesia or mark and may not be. This is the problem that the current installation profiles are trying to solve, but their names don't make a lot of sense (watch the video where leisa and mark try to install drupal).

Hopefully the above helps us address this issue and I haven't blown it out of proportion.

joshmiller’s picture

Follow up on my #5 above, not only does the homepage only make sense to blogs, it teaches new users that the only place to find their content is on the homepage.

This particular default teaches users the wrong things: A) Drupal is an out of the box blogging platform and B) This is where I can find my content if I can't figure out the menu system.

Neither need to happen.

emmajane’s picture

We bashed around the idea a little bit more in IRC on Friday (?) night. I'm currently leaning away from having the message contained in an editable block and am leaning towards the following:

"Welcome":
- after installing Drupal user is redirected to admin/welcome
- the welcome message is always available from a tab on /admin. For example: [Modules] [Tasks] [Welcome]
- this screen is also available through a menu link in the "Navigation" menu.
- the screen is possibly renamed, "Getting Started" or "Help" instead of "Welcome."

Home:
- For authenticated users: page displays some variation on "You have not created any content, please add some." with a link to node/add.
- For NON-authenticated users: page displays some variation on, "" Yes. Nothing. :) Not a 404 or a message saying that the site maintainer still needs to add content or anything. Just plain ol' nothing.

Edit: replaced my clever <front> with "home."

webchick’s picture

I think what's happening with the divergent opinions in this issue and is that two separate issues are being a big tangled up into one, by nature of the way that the current welcome screen works:

Issue #1: There needs to be some general howto instructions for people installing and using Drupal that apply to any site they're building, no matter what. (explaining modules, themes, configuration screens, creating content, etc.). This is a reference document, should be admin-facing only, and can't go away when people add their first piece of content.

Issue #2: People are also suggesting at #79582: Add example content to the experimental out-of-the-box demo install profile of having the default profile auto-create one or more pieces of content (unique to each installation profile) to help train people on how content works. This could be set as the default front page in the default profile so that Drupal is not so "blog like" out of the box, and users can learn how to edit, delete, etc. this content.

I think both issues are worth discussing and probably doing. I'm concerned with fixing the first one first.

merlinofchaos’s picture

I just want to throw in this link because this has been discussed elsewhere and I really like yoroy's mockup: http://groups.drupal.org/node/13270

webchick’s picture

(this wasn't at all obvious, but #19 was not related to emmajane's comment, more the side conversation happening at the install profile issue)

Also, merlinofchaos just pointed me to http://groups.drupal.org/node/13270. This looks really promising. So basically, we make the welcome page the default landing for /help. There's already a link to it. And it's where people would reasonably go if they needed help. :)

cburschka’s picture

we make the welcome page the default landing for /help.

+1 That would coincidentally solve the problem that the current help screen isn't exactly friendly, too. :)

catch’s picture

No content in node_default_main() should just be 'No content posted yet' (maybe with a node/add link for users with create content permissions). Using /help for actually helping people seems good to me.

emmajane’s picture

Assigned: Unassigned » emmajane

I am assigning this task to myself and am being coached by webchick, merlinofchaos and catch.
The Plan, by emmajane: The patch will move the current "welcome" text to /admin/help and leave the front page blank. The final screen of the install profile will link to the new help page instead of the front page.

webchick’s picture

Just a note to say that I approve of this plan.

Follow-up issues could include, but not be limited to:

a) Put something other than nothing on the default front page when no content is posted. I predict this will need some back and forth to get just right.
b) Add a mechanism for installation profiles to choose their redirection path upon completion, rather than it being hard-coded to the new /help page.
c) Have the default profile add some sample content so that users get a nice introduction to editing and deleting content.
d) Make the text that's there more useful.

pasqualle’s picture

#126221-47: Make 'node' empty text themable.
yes, the welcome message should be a help page.

yoroy’s picture

So for now we're not really rewriting the actual content of the screen right? Well for future reference then:
- There's something about ending installation on the Help index that spells admitting defeat before letting people try.
- meaning: getting started page !== help index page. Especially for the first time experience we need something more focussed then an overview of all the things we have help text on.

Frankly, the new empty homepage catch describes in #23 to me sounds like a better start than a help page.

__

No content posted yet, Go create some!

or read the getting started guide

__

The less options we offer initially, the smaller the chance people get lost after their first click. That said, please do continue with the plan.

yoroy’s picture

Oops, don't think the plan is to end installation on the help *index* but on a specific "welcome, get started" page. Good.

catch’s picture

When the followup patch for redirects to other pages goes in, default could go to /help (or help/welcome or whatever), and minimal could go to .

webchick’s picture

@yoroy: Well. The getting started page == the help index page, so yeah, it's one in the same.

I guess I see your point. "Drupal is hard. We'll toss you right at the main /help screen because boy are you going to need it!" I'm not really into the idea though of having help in Drupal that's treated completely different from the rest of the help, though.

I suppose one option is adding another link to the end of the installer to "View help to get started"? Then you could go to either your blank home page (which can eventually have the "Create content" text on it) or the getting started page.

Would that help?

pasqualle’s picture

StatusFileSize
new2.8 KB

the large step forward

merlinofchaos’s picture

/help needs to be made a lot more friendly and a lot nicer. There is absolutely nothing wrong with starting there. If we treat it like a "Here's a bunch of things you can do with this software" I doubt any user will be upset by getting sent to that. It's common sense, right?

emmajane’s picture

StatusFileSize
new7.55 KB

The attached patch does the following:

1. Updates the final screen of the installer to point people to the front page AND the help system. See screen shot at: http://www.flickr.com/photos/emmajane/3586437555/
2. Updates the front page of Drupal to REMOVE the "Welcome screen."
3. Updates the front page of the help system to use the "Welcome screen" text.

boris mann’s picture

@emmajane "The final screen of the install profile will link to the new help page instead of the front page."

This should be configurable. Specifically, we need to support potentially two things:

* make the final link of installation configurable per install profile (defaults to /help if no value given - needs a variable to set this as part of install, probably just a return value in one of the profile_ functions)
* allow a function to set the value / contents of /help in the install profile

Re: "Drupal is so hard, it defaults to /help"

Or: "Drupal is so awesome, there is this great page telling me what I can do next"

One option is to special case this on install and show a "teaser" from /help on the front page, with a jquery "hide this".

emmajane’s picture

Status: Active » Needs review
StatusFileSize
new7.65 KB

Revised patch attached. Please note the link should now be correctly implemented using the l() function.

yoroy’s picture

Status: Needs review » Active

Re: "Drupal is so hard, it defaults to /help"
Or: "Drupal is so awesome, there is this great page telling me what I can do next"

Yes and my point is, those are two different pages.
__

Must nitpick the wording on the flickr pic a bit. (these are new strings, right? else, disregard) Always try to omit needless words:

- Remove the "You may now", just use "Visit your new site."
- The last line about more info about configuring…etc. could just be a linked "Configuration help" or even just "Help".

yoroy’s picture

Status: Active » Needs review

oops

catch’s picture

Status: Needs review » Needs work

Should use theme('image').

catch’s picture

@yoroy, there's no new text here apart from the alt text - the comment is just so we change that to something else before release.

webchick’s picture

Status: Needs work » Needs review

@Boris Mann: All of those sounds like good things to do; none of them are related to getting the current default text into the help system. :) That's the scope of this patch.

emmajane’s picture

StatusFileSize
new7.4 KB

Revised patch attached. Due to discrepancies in favourite bike colour, the shed has been removed.

emmajane’s picture

StatusFileSize
new7.4 KB

Fixing awkward language in the TODO comment.

matt2000’s picture

webchick wrote:

d) It's the ONLY help we offer people when they install Drupal and it DISAPPEARS COMPLETELY when you add your first piece of content. (I know there's an issue for this too! Grr!)

Here's one: #240721: UMN Usability: Make Drupal more helpful
and another: #126221: Make 'node' empty text themable.

Probably now obsolete based on this thread...?

webchick’s picture

Status: Needs review » Needs work
+    $output .= '<p>' . st('For more information on configuring Drupal, please refer to the <a href="@help">online help pages</a>.', array('@help' => url('admin/help'))) . '</p>';

Let's go with something like "help section" rather than "online help pages"... online help implies drupal.org and this is not that.

Screenshots for UX folks:
Final page of installer: http://img.skitch.com/20090601-f9tu591jscshn1ffd2mwgggau2.png
Landing page of help section: http://img.skitch.com/20090601-xky1gf33g8gqth2tib78217csq.png
Default front page: http://img.skitch.com/20090601-ds6utt33dj57xis75yf6w79xr5.png

After actually playing around with this, even though I know I said back in whatever reply that we weren't going to deal with the default content message here, we really need to deal with the default content message here. :\ A totally blank page looks too much like a bug.

My initial thought was just copy/paste from Blog module and do something like:

"No content has been created.

* Create new content. (only displayed if they have permissions)"

However, that doesn't really work here because this page doesn't show all content, only promoted content. "No promoted content" means explaining wtf "promoted" means.

"No front page content created" maybe?

webchick’s picture

Brainstorming with merlinofchaos on IRC:

[19:51]  <webchick> "No front page content has been created."
[19:51]  <webchick> * Create content
[19:51]  <webchick> * Change site front page
[19:51]  <merlinofchaos> YES
emmajane’s picture

Status: Needs work » Needs review
StatusFileSize
new7.86 KB

Revised patch attached with new front page text. Please see revised home page screen shot at:
http://www.flickr.com/photos/emmajane/3586756259/

Status: Needs review » Needs work

The last submitted patch failed testing.

emmajane’s picture

Status: Needs work » Needs review
StatusFileSize
new8 KB

I don't understand at all why drupal_set_title() is breaking simpletest, but I've taken it out and have gone back to no heading on the front page. I don't think it's as nice, but it should pass the tests.

The offending line was:
drupal_set_title( t('Welcome to ') . variable_get('site_name', 'Drupal'));

webchick’s picture

Those test failures look very suspicious.

But in the meantime:

+    $output = '<p>' . t('Please follow these steps to set up and start using your website:') . '</p>';
+    $output .= '<ol>';
+    $output .= '<li>' . t('<strong>Configure your website</strong> Once logged in, visit the <a href="@admin">administration section</a>, where you can <a href="@config">customize and configure</a> all aspects of your website.', array('@admin' => url('admin'), '@config' => url('admin/settings'))) . '</li>';
+    $output .= '<li>' . t('<strong>Enable additional functionality</strong> Next, visit the <a href="@modules">module list</a> and enable features which suit your specific needs. You can find additional modules in the <a href="@download_modules">Drupal modules download section</a>.', array('@modules' => url('admin/build/modules'), '@download_modules' => 'http://drupal.org/project/modules')) . '</li>';
+    $output .= '<li>' . t('<strong>Customize your website design</strong> To change the "look and feel" of your website, visit the <a href="@themes">themes section</a>. You may choose from one of the included themes or download additional themes from the <a href="@download_themes">Drupal themes download section</a>.', array('@themes' => url('admin/build/themes'), '@download_themes' => 'http://drupal.org/project/themes')) . '</li>';
+    $output .= '<li>' . t('<strong>Start posting content</strong> Finally, you can <a href="@content">add new content</a> for your website. This message will disappear once you have promoted a post to the front page.', array('@content' => url('node/add'))) . '</li>';
+    $output .= '</ol>';
+    $output .= '<p>' . t('For more information, please refer to the specific topics listed in the next section, or the <a href="@handbook">online Drupal handbooks</a>. You may also post at the <a href="@forum">Drupal forum</a>, or view the wide range of <a href="@support">other support options</a> available.', array('@help' => url('admin/help'), '@handbook' => 'http://drupal.org/handbooks', '@forum' => 'http://drupal.org/forum', '@support' => 'http://drupal.org/support')) . '</p>';

That entire section looks like it needs to be indented (so it's aligned with return $output below).

+    drupal_set_title( t('Welcome to ') . variable_get('site_name', 'Drupal'));

a) There shouldn't be a space before t(
b) For translators this should be t('Welcome to @site-name', array('@site-name' => variable_get('site_name', 'Drupal'))

However, if we're going to get this fancy, we should probably put this entire section in a theme function, too, so that people can change its output. Do you hate me yet? :P

+        l( t('Create content.'), 'node/add' ),
+        l( t('Change the default front page.'), 'admin/settings/site-information' ),

A couple of things:

1. There shouldn't be spaces between l( and t(, nor ' and )
2. I know I said to copy from blog.module, but it's pretty jarring to have the periods at the end of those links. Let's remove them.

emmajane’s picture

StatusFileSize
new10.18 KB

Fixes made according to webchick's review and simpletest tests updated to reflect the revised title.

@webchick: about the theme wrapper...how about I just buy you a bucket of ice cream every time a themer writes a customized tpl.php file to replace the default text? It'll be easier for both of us. :)

emmajane’s picture

StatusFileSize
new10.42 KB

Same patch now with less white space. Hopefully.

webchick’s picture

Status: Needs review » Fixed

I could find nothing else wrong with this (and neither could the folks in #drupal), so.... committed to HEAD! :)

Follow-up issues to this one:
a) Tweak the words on the help landing page: #423724: Help landing page: what should be on it, how would it look.
b) Make the default install profile create a "welcome" node? #79582: Add example content to the experimental out-of-the-box demo install profile
c) Fix the help system so that it doesn't suck: #299050: Help System - Master Patch

Possibly others, too. The important thing is that the main issue is solved and can now be built upon. Thanks so much for all of your help, folks! :) And w00t @ emmajane's first core patch!

boris mann’s picture

Status: Fixed » Needs review

"every time a themer writes a customized tpl.php file to replace the default text"

This is again going OT, but this is unlikely to be a theme function. Where is this text "stored"? The front page content is what should go into the install profile (in this case, default.profile).

Can we commit the help bits, and move the front page content out of this patch? Again, my goal here is to have really nice default.profile that other people can look at for overriding...

boris mann’s picture

Status: Needs review » Fixed

Sorry, setting back.

webchick’s picture

@Boris: Yep. I want that too. Let's figure out what default.profile's node/1 is at #79582: Add example content to the experimental out-of-the-box demo install profile.

dww’s picture

Status: Fixed » Needs work

Argh! Why is this still hard-coded HTML, not a theme function as per the (once-upon-a-time) point of #126221: Make 'node' empty text themable.?

pasqualle’s picture

Maybe because nobody should see that message twice, and maybe we do not theme messages, and maybe it should come from an install profile (in a followup issue).
I guess if I install in expert mode I will see a blank page only, so there is nothing to theme..

catch’s picture

Status: Needs work » Fixed

There's at least one other open issue which changes this to a theme function, and there's less of it now, so let's do it one of those.

webchick’s picture

@dww: Because none of the other "There is no content here. Would you like to create some?" messages are wrapped in a theme function, and neither are any other pages in the help system.

If we want to add one, we can do so in another issue.

boris mann’s picture

dww - I was torn about this tiny tiny piece of default text. I think only the "minimal" install profile will ever see this - default and other profiles will do [79582]

I considered arguing for even this text to be moved into the install profile, but I think it's fine.

dww’s picture

Re: If we want to add one, we can do so in another issue.

That's what #126221: Make 'node' empty text themable. was for during most of its life, and was recently marked duplicate/won't fix with this issue...

/me gives up. ;)

webchick’s picture

I didn't mark it that way. /me shrugs

dww’s picture

I'm not saying you did. ;) I'm just saying these meta issue initiatives can be difficult to navigate since not everyone (including me) reads every issue associated with the thing, and different people have different ideas about the scope of each part. So, the main thrust of the folks in this issue has been "change how the thing basically works, clean up everything in sub-issues", and yet people comment in the sub-issues saying "this is being subsumed by the main issue, there's nothing more to do here..."

/me shrugs, too.

webchick’s picture

Ok, well. Now I did. ;) #126221-69: Make 'node' empty text themable.

Hopefully this addresses all remaining concerns with this patch and we can move on to fixing the other related issues, now.

@dww: The only thing this patch did was move the welcome message into /help. That's it. It's classic scope-creep combattance that's needed when an issue takes 4 releases to solve. So yes. Things that are not related to moving the welcome message into /help need to be dealt with elsewhere.

matt2000’s picture

@ #59 , #57 above

This is an example of when a message needs themeing...

#423724-7: Help landing page: what should be on it, how would it look.

Yes, the vanilla message text can come from one function, but then that need to pass through a theme function to add all the nifty icons and columns and such.

The fact that people might misuse theme functions to change content is not an argument to disregard the theme function. The fact that people might drive over kittens is not an argument to disregard cars. I prefer my bike in the shed...

(Holy mixed metaphors, Batman. I don't even know what that means anymore.)

So which is the correct issue thread for discussing a theme function for this?

webchick’s picture

If/when #423724: Help landing page: what should be on it, how would it look. materializes into something, we can wrap its output in a theme function. Until then, it's just standard help text which is simply returned from hook_help() like every other piece of help text in Drupal.

rfsbsb’s picture

@emmajane I noticed you get all the messages that was on /node to /help, but now you must delete the 4th item:

"Start posting content Finally, you can add new content for your website. This message will disappear once you have promoted a post to the front page."

It's not necessary anymore.

It's getting better, congrats!

webchick’s picture

Status: Fixed » Needs work

How on earth did I miss that?

Thanks, rfsbsb! Are you up for a quick patch to remove that line?

tic2000’s picture

patch to remove the 4th line

tic2000’s picture

Status: Needs work » Needs review
StatusFileSize
new2.26 KB

where did my patch go?

webchick’s picture

Status: Needs review » Needs work

Well. That's a little overkill in terms of deletion. Let's just get rid of the part that lies to people. :)

tic2000’s picture

StatusFileSize
new2.45 KB

Let's try again :)

PS. Something strange happens. First time it saved the comment but not the attachment. Now it saved the attachment, but not the comment. Fortunately I can edit my comments :)

tic2000’s picture

Status: Needs work » Needs review

And proper status

pasqualle’s picture

catch’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Latest patch is good.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new2.28 KB

It seems there were a few other places that lied to people (in particular anyone who installs with the expert profile).....

For example, the expert profile (and potentially other profiles too) doesn't come with the help.module installed and doesn't have any content types you can create, so we should avoid linking to those pages because the links will be broken.

Lying is bad, especially on the front page of the site :) This patch should fix it, I think.

Bojhan’s picture

Not sure if we fixed it, or just made it worse :) It was already pretty oke, from several tests - lets hope it will for next test.

Status: Needs review » Needs work

The last submitted patch failed testing.

tstoeckler’s picture

Status: Needs work » Needs review

TestBot was broken...

Status: Needs review » Needs work

The last submitted patch failed testing.

David_Rothstein’s picture

Status: Needs work » Active

My patch in #78 was kind of a trivial bugfix, but posting it as a followup here did not exactly generate the quick RTBC that I figured would happen.... oh well :)

In the meantime, someone else posted the bug independently at #510782: Installer links to help module and other pages even when they are not available and started working on it, so I've merged my code with the patch there.

I'm moving this issue back to "active" based on @Bojhan's comment in #79, although if that is no longer relevant then this can just be closed.

emmajane’s picture

Status: Active » Needs review
StatusFileSize
new4.37 KB

Just looked at the welcome screen with fresh eyes on a new install. There were three "please"s. Patch attached to remove my Canadian-isms. :)

Bojhan’s picture

Nice catch, can you confirm that this patch also includes David's changes? If yes, then RTBC

emmajane’s picture

it does not include any other changes and only removes the "pleases" as David's requested patch was fixed/committed in #510782: Installer links to help module and other pages even when they are not available.

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Ok, then the patch in #84 is RTBC

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +revisit before beta

LOL. Committed to HEAD. :)

Tagging as "revisit before release", pending results of testing.

webchick’s picture

Oh. I should point out though that if this ends up testing badly, the solution is going to be for default.profile to create a sample node with guiding instructions, not going back to hard-coded crap that existed before. There's no reason for experts to have this junk in their face.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Usability, -DrupalWTF, -D7UX, -revisit before beta, -Needs usability testing

Automatically closed -- issue fixed for 2 weeks with no activity.