This module looks really great to me. iframes strike me as a little bit sturdier than AHAH inserts, so I'm eager to begin using it.

The latest development releases of jQuery UI module no longer rely on jQuery Update.

jQuery Update DRUPAL-6--2 supports jQuery 1.3, but it's not really finished yet. Some issues remain with drag and drop.

I was able to run the examples by commenting out the jquery_update requirement in this module's info file, no jQuery Update module and jQuery UI 1.6. Does this module really require jQuery 1.3 and the jQuery Update module?

Comments

markus_petrux’s picture

markus_petrux commented
Status: Active » Fixed

Yes. This module makes use of jQuery UI Dialog plugin 1.7.1, and that requires jQuery 1.3.x. So you need the latest development snapshot of the jquery_update module.

Why this module requires jQuery UI Dialog plugin 1.7.1? Well, the jQuery UI API has changed a bit from version to version and this module needs features that are only present on latest version. I also plan to keep this module in sync with any future implementation of jQuery UI Dialog. Also, the jQuery UI core library introduces a few extensions to jQuery itself, and that's second reason Modal Frame requires latest versions of jQuery stuff.

PS: I avail this opportunity to comment that I realized version 1.0 of Modal Frame needs a bit more love, and I'm working hard to fix all remaining issues. Not all is reported in this issues queue. It should not affect the API, but the inners. So please, bear this in mind. I expect to get it during the next couple of days, more or less.

Anonymous’s picture

Anonymous (not verified) commented

are you absolutely sure it requires 1.7.1? Why does my experience show that the module works with jQuery UI 1.6? What am I not seeing?

markus_petrux’s picture

markus_petrux commented
Status: Fixed » Active

Ah, 1.6! Nope. I'm sure it doesn't work with jQuery UI 1.5.x. But 1.6 I'm not sure.

I expect to commit later today the changes I mentioned earlier... which is a must to fix several issues. I will then check how it works with jQuery UI 1.6, and if that works, then we could relax the module requirements, which would be good news.

I'll update this issue after the commit, so you can test it as well, and see too. :)

Thanks for the heads up.

markus_petrux’s picture

markus_petrux commented
Version: 6.x-1.0 » 6.x-1.x-dev

Well, I just committed the fixes.

http://drupal.org/cvs?commit=218166

It should be available from direct CVS checkout, or waiting a few hours for the next development snapshot.

Please, let me know if it works for you using jQuery 1.2.6 and jQuery UI 1.6. If so, then I'll remove the requirement from the module .info file.

Anonymous’s picture

Anonymous (not verified) commented

Using jQuery UI 1.6, jQuery 1.2.6 is good with this code.

I don't remember seeing iframe pages in my browser history, though. Is that new? The iframe'd pages appear in my browser history.

markus_petrux’s picture

markus_petrux commented
Status: Active » Fixed

Using jQuery UI 1.6, jQuery 1.2.6 is good with this code.

Sweet. Thanks for confirming this. I'll remove the dependency of jquery in the module .info file.

I don't remember seeing iframe pages in my browser history, though. Is that new? The iframe'd pages appear in my browser history.

Nope. It shouldn't. I have opened a separate issue for this: #477194: Prevent child navigation from affecting parent's history

The current issue was about jquery_update, and this is resolved now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.