Hi, I try to dive in this module..

Could someone tell me, in what case the href anchor is added to the url? Or shouldn't it never? I got this, if i click two times on a tab, then I get #... in the url.

Is it possible to grab the tab ID from the url somehow? Or is this href only a hash?

Cheers

Comments

sirkitree’s picture

sirkitree commented
Status: Active » Needs review

I actually just made a quick patch that will select the specified tab if you link to the specific anchor.

Index: tabs.js
===================================================================
--- tabs.js	(revision 243)
+++ tabs.js	(working copy)
@@ -85,5 +85,9 @@
     $tabsContent.append('<span class="clear"></span>');
     i++;
   });
+  // is the anchor is specified, click that tab
+  if (window.location.hash !== '') {
+    $tabs.tabs('select', window.location.hash);
+  }
 };
bnubbz’s picture

bnubbz commented

This doesn't work. Does it actually work for you? I have something like http://mysite.com/project-template#2 and it should take you to the second tab but it doesn't.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Closed (won't fix)

Tabs work if the page is manually loaded to the hash of the tab's anchor.

To accomplish this:
* On a page with tabs, hover over a tab to determine the hash (path component beginning # at the end of the URL.
* On a different page, link to the page with tabs, including the hash in the href.

bnubbz’s picture

bnubbz commented

This does not work like you say it does. I've never understand how the tab could be linking to a page with the hash but when I type that into the URL it doesn't take me to that tab.

Do I have to provide a link on another page? I would think I could just type it into the URL manually and it works the same way. It would be very nice if this would work for what I'm trying to accomplish. Thanks!

Edit: I just tried this and it only works if you provide a link on a different page ... weird. Any reason this happens?