Module is working as expected, but once I start using uc_discounts_alt (http://drupal.org/project/uc_discounts_alt) the prices get mixed up. uc_discounts_alt uses the sell prices to calculte the discount and the price alterer isn't running in the message displayed, so it shows the sell price without VAT, while the shopping cart shows the price including VAT.

BTW this can be an uc_discounts_alt problem, so I'll create another issue there.

Comments

attiks’s picture

attiks commented

Issue for reference #476348: Incompatible with Ubercart 2 VAT support

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Category: bug » feature
Status: Active » Postponed

uc_discounts_alt currently calls uc_currency_format() to display prices, but it should be calling uc_price() instead so they go through the price alterer and have VAT added as necessary. Once this is done, specific support may still be required in uc_vat, though this depends on the outcome of #475474: Price alterer contexts and VAT support. Marking as postponed for now.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed » Fixed

Specific support is no longer needed in uc_vat as of rc7. Other modules instead have to call uc_price() with the correct 'type' context in order for prices to have VAT added.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.