In the HTML that the advf forum listing spits out for the forum listing table, the rows showing threads don't display the container they belong to properly. Instead these all come up as being in 'container-0' - like this: "odd middle-row in-container-0"

I think this was once working properly (guessing that as it would have been needed by the collapsible containers project which seemed to make use of this) - but trying to find the fix for this is a bit beyond me.

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Yeah, that was probably a bit of the collapsable containers code that was ripped out. Must have missed a bit of it. I don't know if it's worth removing now in 1.0. I'll have to look and see how entrenched it is.

Michelle

dannz’s picture

dannz commented

It would be really nice to get this working - rather than removing it - i.e. so it does display the correct container rather than 0. Otherwise better to leave as is - it's not doing any harm, and later down the track it could be fixed and got working.

BTW - this might be something that can be considered in 'meta-architecture' - i.e. so all data that is available to styling and in Drupal (e.g. forum_depth, id, etc. can easily be set as a class for specified elements (e.g. containers, threads, posts).

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Active » Closed (won't fix)

I still would like to get collapsable containers working but it's not going to happen in 1.x. Possibly in 2.x if the DruBB project needs it, otherwise 3.x. If it's not actually hurting anything, I'm just going to leave it alone. There's going to be so much refactoring in the next couple of versions that it's not worth it to track it down now.

Michelle