Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
trigger.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 May 2009 at 22:18 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
andypostHere another fix, but this one require #408434: Actions.inc: fatal error after DBTNG conversion
Comment #2
andypostForget to clean commented code
Comment #3
andypostTaxonomy trigger changed to run without foreach loop so $term as parameter needs to be tested if actions execution change it.
Is chained actions need a fresh copy of object in actions_do()? Suppose needs test because action function can receive arguments by reference.
In old implementation $object was always old not changed.
Comment #4
andyposttrigger the bot
Comment #5
andypostso re-test is needed
Comment #6
andypostre upload same patch
Comment #7
berdirPatch looks good, seems like a nice simplification. As it was basically my idea, I can't really rtbc it :)
Comment #8
mr.baileysaa?SELECT aa.aid, a.type FROM {trigger_assignments} aaif ($action_info['type'] != 'user')should use$typeinstead, as $action_info is not defined.The rest of the patch looks ok to me (visual inspection).
Comment #9
andypostComment #10
andypostups, comment was lost on submit
1)
{trigger_assignments}alias aa changed to ta2)
$action_infochanged to$typeSuppose
arg() node_load()should be changed tomenu_get_object()maybe file another issue for this?Comment #11
mr.baileysLooks great, and makes for more readable code... I think this is good to go.
Comment #12
dries commentedCommitted to CVS HEAD. Still needs tests so setting to 'needs work'.
Comment #13
andypostAs I write in #3 There should be a ideas - is data hookable or not?
Comment #14
andypostThere's already enough tests for actions and finally they work after #601398: Simpletest does not allow assigning actions to triggers
also commited tests #306540: Orphaned assigned actions still triggered and cannot be removed
and upcoming #721086: Create tests for system actions, clean up token replacement, clean up triggers